Bug 1176859

This new version is completely rewritten to Go lang. Because I'm not expert at packaging Go I'm getting new SPEC and SRPM files there for a some simple review. It will be nice if somebody will have a free time..

SPEC: https://gist.github.com/jakubjedelsky/7654715
SRPM: http://s.stderr.cz/rpm/asciinema-0.9.9-1.fc22.src.rpm

Hi Jakub,

let me check this out :)

- subpackage devel should contain in BuildRequires and Requires every devel package that provides source code imported in asciinema-devel. So when devel package becomes a dependency of another package, every import path must be presented otherwise building fails.

- terminal, commands and cli folders contains test files which should be run in %check sections if it is possible. This will help you to find out if you have all needed dependencies (all golang import avaiable at build time).
GOPATH=%{buildroot}/%{gopath}:%{gopath} go test %{import_path}/terminal
GOPATH=%{buildroot}/%{gopath}:%{gopath} go test %{import_path}/commands
GOPATH=%{buildroot}/%{gopath}:%{gopath} go test %{import_path}/cli
tested locally on my machine, working.

- golang at least 1.2.1-3 (for definition of %{gopath} and other golang global variables)

The package is just for Fedora? Or for epel6/el7 as well?

Created attachment 981135 [details]
Some possible modifications

Many thanks for review and the patch Honzo, I'll prepare it with  your changes. I forgot for tests, my bad :)

I would like to post it into el7 at least. Should it be a problem? Previous version is in both epel 6/7.

You are welcome :) Well, code.google.com/p/gcfg is not built in el6 (but this should not be a problem). However epel7 has only a minimum number of golang devel packages. Usually with missing branch, so there are no builds for asciinema dependencies. Epel7 is more for Troy Dawson, ccing. Talk to him.

golang-googlecode-gcfg-0-0.4.gitc2d3050.el6 built in el6, tagged into buildroot override, so you can scratchbuild, build and update. It will take 14 days to move build from testing to stable.

kubo's asciinema-0.9.9-1.fc23 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=618737

Hi Jakub,

could you ship Godeps/Godeps.json file with the tarball? This file contains important information about commits of all asciinema dependencies. This way I can track changes and back compatibility issues between updated golang packages.

Thanks
Jan

Hi Jan,

there is version 1.0.0 of upstream available now. Will it be ok to deliver it with this one (if I find a way how to :))?

- k.

Yes, this is ok. If I can ask you, add Godeps.json to %doc of every devel subpackage. %doc Godeps/Godeps.json should do the thing.

Thanks and Thank You.

Jan

kubo's asciinema-1.0.0-2.fc23 completed http://koji.fedoraproject.org/koji/buildinfo?buildID=624224

asciinema-1.0.0-2.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/asciinema-1.0.0-2.fc22

asciinema-1.0.0-2.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.