Bug 1177015

Summary: Trusted forest entry added even when fields are blank
Product: Red Hat CloudForms Management Engine Reporter: Nandini Chandra <nachandr>
Component: UI - OPSAssignee: Milan Zázrivec <mzazrivec>
Status: CLOSED ERRATA QA Contact: Dave Johnson <dajohnso>
Severity: low Docs Contact:
Priority: medium    
Version: 5.3.0CC: jhardy, obarenbo, xlecauch
Target Milestone: GA   
Target Release: 5.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.4.0.0.11 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
: 1193393 (view as bug list) Environment:
Last Closed: 2015-06-16 12:46:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1193393    
Attachments:
Description Flags
screenshot that shows that a trusted forest entry with blank fields can be added none

Description Nandini Chandra 2014-12-23 19:34:38 UTC 
Created attachment 972508 [details]
screenshot that shows that a trusted forest entry with blank fields can be added

Description of problem:
-------------------------
I ran into this issue while verifying bug 1163384.
See attached screenshot.


Version-Release number of selected component (if applicable):
---------------------------
5.3.2.5

How reproducible:
----------------
Always

Steps to Reproduce:
----------------
1. Go to Configuration/Configure
2. Select Current server in Settings Accordion
3. Go to Authentication tab
4. change mode to LDAP
5. Check the checkbox for "Get User Groups from LDAP"
6. In "Trusted Forest Settings" box, click on + sign to Add a new forest
7. While entering new Forest details,leave all the fields blank and then press "Add this entry" button.

Actual results:
---------------
CFME allows a user to add a Trusted forest entry even when fields are blank.


Expected results:
----------------
CFME should not allow a user to add a Trusted forest entry even when fields are blank.

Additional info:
----------------
Comment 3 Milan Zázrivec 2015-02-16 14:27:50 UTC 
https://github.com/ManageIQ/manageiq/pull/1708
Comment 4 CFME Bot 2015-02-16 21:50:59 UTC 
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/9a4b554c952faf37dfc66b475c5b24beaf48f93c

commit 9a4b554c952faf37dfc66b475c5b24beaf48f93c
Author:     Milan Zazrivec <mzazrivec>
AuthorDate: Mon Feb 16 15:24:39 2015 +0100
Commit:     Milan Zazrivec <mzazrivec>
CommitDate: Mon Feb 16 15:43:03 2015 +0100

    UI: don't allow to add an empty ldap forest entry
    
    The LDAP hostname has to be set -- we cannot be adding a new forest
    entry without an LDAP hostname to the set of existing LDAP hosts.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1177015

 vmdb/app/controllers/ops_controller/settings.rb | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
Comment 5 Nandini Chandra 2015-03-07 02:52:34 UTC 
Verified that this issue doesn't occur in master.20150306140042_57a1769
Comment 8 errata-xmlrpc 2015-06-16 12:46:45 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html