Bug 1177147

Summary:	Null disk size on a newly created disk is interpreted 0. Leave as null and revise usage.
Product:	[Retired] oVirt	Reporter:	Vered Volansky <vered>
Component:	ovirt-engine-core	Assignee:	Vered Volansky <vered>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Ori Gofen <ogofen>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	3.5	CC:	acanan, amureini, bugs, cmestreg, ecohen, gklein, lsurette, ratamir, rbalakri, tnisan, vered, yeylon, ylavi
Target Milestone:	---
Target Release:	3.5.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	storage
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-04-29 06:16:20 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Storage	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1182012, 1193058, 1196662, 1197441

Description Vered Volansky 2014-12-24 14:34:52 UTC

Description of problem:
When creating a Storage Domain, the available disk size is set to null, to be polled later on.
When Adding a disk on a newly created domain, CDA fails on storage allocations - StorageDomainValidator.isDomainWithinThresholds. This happens since the null value is interpreted as 0 in StorageDomainDynamic.getfreeDiskInGB() .

Revise when this interpretation is correct and handle when it's not (isDomainWithinThresholds, at least).


Steps to Reproduce:
1. Create a new Storage Domain
2. Immediately add a disk.
3.

Actual results:
CDA failure - ACTION_TYPE_FAILED_DISK_SPACE_LOW_ON_STORAGE_DOMAIN .

Expected results:
Pass (or fail on execution due to actual lack of space, which is not the interesting case here to verify).

Comment 1 Eyal Edri 2015-02-26 12:31:44 UTC

this ovirt bug was fixed during 3.5.1 cycle and is included in the build, and therefore should be verified.

Comment 2 Allon Mureinik 2015-03-17 15:07:18 UTC

*** Bug 1202363 has been marked as a duplicate of this bug. ***

Comment 3 Carlos Mestre González 2015-03-17 15:32:40 UTC

We've encountered this issue in 3.5.1 (vt14) in automation.

What is the solution implemented for this? The disk creation should fail? With what message? Right now adding a vm fails with:

'Cannot add VM. Low disk space on Storage Domain iscsi_2.'

Comment 4 Vered Volansky 2015-03-19 07:57:48 UTC

> What is the solution implemented for this? The disk creation should fail?
No, disk creation should succeed.

> With what message? Right now adding a vm fails with:
> 
> 'Cannot add VM. Low disk space on Storage Domain iscsi_2.'
This is not the desired behaviour.
I've verified the patch is indeed in vt14, yet I can't reproduce.
For me, disk creation completes under these conditions.

Please explain exactly how you reproduced, and attach logs.

Comment 5 Carlos Mestre González 2015-03-19 10:36:29 UTC

Sorry Vered, I saw this issue in the previous build, not this one.

Comment 6 Allon Mureinik 2015-03-19 12:45:27 UTC

So can we try to reproduce with this build, and if we can't, move this BZ to VERIFIED?

Comment 7 Aharon Canan 2015-03-19 13:23:59 UTC

need to verify, no needinfo needed here.

Comment 8 Carlos Mestre González 2015-03-19 13:25:18 UTC

Just to clarify, my comment 3 was refering to activating the storage domain in vt14, bug 1202363. Vered reopened because that case is different from this one (different flow according to the bug description).

I haven't try to verify this case, I'll do it and mark is as VERIFIED in case I can't reproduce.

Comment 9 Allon Mureinik 2015-03-19 13:27:18 UTC

(In reply to Carlos Mestre González from comment #8)
> Just to clarify, my comment 3 was refering to activating the storage domain
> in vt14, bug 1202363. Vered reopened because that case is different from
> this one (different flow according to the bug description).
> 
> I haven't try to verify this case, I'll do it and mark is as VERIFIED in
> case I can't reproduce.
Thanks for the clarification - I misunderstood that.

Comment 10 Ori Gofen 2015-03-22 12:19:25 UTC

I have executed this scenario twice, first time before domain's creation, operation has failed because of the storage domain status was still "lock":
"Cannot add Virtual Machine Disk. The relevant Storage Domain's status is Locked."

Second time, right after Domain creation, on the second time the operation was successful.
seems it should be verified, Carlos do you have any comments before I'm verifying this?

Comment 11 Ori Gofen 2015-03-23 11:20:12 UTC

Carlos, has reached the same results as me via manual testing thus, verified on vt14.1

Comment 12 Eyal Edri 2015-04-29 06:16:20 UTC

ovirt 3.5.2 was GA'd. closing current release.