Bug 1177549

Summary: NetworkManager prefers userspace PPPoE to kernel PPPoE
Product: [Fedora] Fedora Reporter: Simon Farnsworth <simon>
Component: NetworkManagerAssignee: Lubomir Rintel <lkundrak>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: 21CC: dcbw, psimerda
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-02 06:35:30 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
kernel pppoe patch none

Description Simon Farnsworth 2014-12-28 23:10:21 UTC
Description of problem:

NetworkManager prefers to run /usr/sbin/pppoe on a pty for PPPoE connections, rather than using the rp-pppoe.so plugin. This both costs CPU time, and reduces the feature set of PPPoE on Fedora.

Version-Release number of selected component (if applicable):

0.9.10.0-14.git20140704.fc21

How reproducible:

Always

Steps to Reproduce:
1. Set up a PPPoE connection
2. Connect
3. Note via ps that /usr/sbin/pppoe is in use, rather than the rp-pppoe.so plugin, and thus that PPPoE jumbograms are not available (1492 MTU instead of the supported 1500 MTU on the PPP connection)

Actual results:

PPPoE connections use /usr/sbin/pppoe to handle the PPPoE side, which consumes more CPU time, *and* doesn't permit the use of RFC 4638 jumbograms for 1500 MTU.

Expected results:

PPPoE connections use the rp-pppoe.so plugin, to get the kernel to handle the PPPoE side, for reduced CPU use under load and RFC 4638 jumbograms.

Comment 1 Simon Farnsworth 2015-01-14 22:39:34 UTC
Attached patch against F21's NM fixes this for me. I'll be filing a version of the patch against git master for upstream's consideration, and will update this bug when I've done so.

Comment 2 Simon Farnsworth 2015-01-14 22:40:07 UTC
Created attachment 980241 [details]
kernel pppoe patch

Comment 3 Simon Farnsworth 2015-02-15 16:34:24 UTC
https://bugzilla.gnome.org/show_bug.cgi?id=742939 is the upstream report - there's a kernel patch to cover the reason for NetworkManager regressing to userspace PPPoE, and two patches to NetworkManager to make it able to use either PPPoE implementation and to sort out PPPoE MTUs.

Comment 4 Dan Williams 2015-04-14 15:19:25 UTC
The kernel patch is in net-next since 2015-03-04. https://git.kernel.org/cgit/linux/kernel/git/davem/net-next.git/commit/?id=287f3a943fef58c5c73e42545169443be379222f

Comment 5 Dan Williams 2015-05-11 15:21:03 UTC
Might also want this additional kernel patch.  Simon, does Felix's patch here look legit?

https://patchwork.ozlabs.org/patch/470384/

Comment 6 Simon Farnsworth 2015-05-13 09:32:30 UTC
(In reply to Dan Williams from comment #5)
> Might also want this additional kernel patch.  Simon, does Felix's patch
> here look legit?
> 
> https://patchwork.ozlabs.org/patch/470384/

It does, yes.

Comment 7 Fedora Admin XMLRPC Client 2015-08-18 14:58:17 UTC
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.

Comment 8 Fedora End Of Life 2015-11-04 10:47:55 UTC
This message is a reminder that Fedora 21 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 21. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '21'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 21 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 9 Fedora End Of Life 2015-12-02 06:35:34 UTC
Fedora 21 changed to end-of-life (EOL) status on 2015-12-01. Fedora 21 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.