Bug 1177767

Summary:	make uninstall leaves two symlink files
Product:	[Community] GlusterFS	Reporter:	Raghavendra Talur <rtalur>
Component:	build	Assignee:	Raghavendra Talur <rtalur>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	pre-release	CC:	bugs, gluster-bugs
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-14 17:28:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Raghavendra Talur 2014-12-30 11:29:40 UTC

Description of problem:
In a source installed glusterfs, make uninstall does not remove two symlink files that were created as part of make install.

Files are
$(DESTDIR)$(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/performance/stat-prefetch.so
$(DESTDIR)$(libdir)/glusterfs/$(PACKAGE_VERSION)/xlator/features/access-control.so


How reproducible:
Always

Steps to Reproduce:
1. Install gluster using source
2. Uninstall with make
3. ls -lR on $LIBDIR


Actual results:
Two files are found in ls output.


Expected results:
No files should be left over.

Comment 1 Anand Avati 2014-12-30 11:48:56 UTC

REVIEW: http://review.gluster.org/9367 (build: Remove files completely in make uninstall.) posted (#1) for review on master by Raghavendra Talur (rtalur)

Comment 2 Anand Avati 2014-12-30 11:49:36 UTC

REVIEW: http://review.gluster.org/9367 (build: Remove files completely in make uninstall.) posted (#2) for review on master by Raghavendra Talur (rtalur)

Comment 3 Anand Avati 2014-12-30 11:54:11 UTC

REVIEW: http://review.gluster.org/9367 (build: Remove files completely in make uninstall.) posted (#3) for review on master by Raghavendra Talur (rtalur)

Comment 4 Anand Avati 2014-12-30 12:55:19 UTC

REVIEW: http://review.gluster.org/9367 (build: Remove files completely in make uninstall.) posted (#4) for review on master by Raghavendra Talur (rtalur)

Comment 5 Anand Avati 2015-01-01 11:10:34 UTC

COMMIT: http://review.gluster.org/9367 committed in master by Niels de Vos (ndevos) 
------
commit c8263975862afa9e5afc603bf2d05ab93087bcc4
Author: Raghavendra Talur <rtalur>
Date:   Tue Dec 30 17:16:57 2014 +0530

    build: Remove files completely in make uninstall.
    
    If we create symlinks are part of make install,
    should remove them as part of make uninstall.
    
    Change-Id: Ie6e641caed60104cd256de4f020c1c6743d4ae60
    BUG: 1177767
    Signed-off-by: Raghavendra Talur <rtalur>
    Reviewed-on: http://review.gluster.org/9367
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 6 Niels de Vos 2015-05-14 17:28:47 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:35:46 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:38:09 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:45:24 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user