Bug 1178528 (python-send2trash)
| Summary: | Review Request: python-send2trash - Python module to send files to trash natively | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Krause <chkr> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED DUPLICATE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | chkr, e, kevin, mhroncok, package-review |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2018-01-09 11:59:14 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1173410 | ||
|
Description
Christian Krause
2015-01-04 15:07:51 UTC
Do we really want to use mixed case in the package name? The module name to import from Python is all lowercase, the GitHub project also uses all lowercase, only the pypi page uses mixed case. I just checked: other python packages, e.g. python-werkzeug, are in the same category: - mixed-case tarball name - mixed-case directory in tarball - mixed-case in egg-info - but lowercase package name I'll change the package name in the next few days unless there are any objections. Here are the update files using a lowercase package name: Spec URL: https://chkr.fedorapeople.org/review/python-send2trash.spec SRPM URL: https://chkr.fedorapeople.org/review/python-send2trash-1.3.0-1.fc20.src.rpm You must update your spec file: 1. Provide python2 and python3 subpackages. 2. Update the python macros 3. Use the python-provides macro 4. Ping upstream about include the license text in the tarball (In reply to William Moreno from comment #4) > 2. Update the python macros By this I think he meant to use the %py2_build, %py3_build, %py2_install, and %py3_install macros, as shown here: https://fedoraproject.org/wiki/Packaging:Python#Example_common_spec_file Any update here? I need this package. Will open a new review request, given there's no reply to a needinfo for 2 years. *** This bug has been marked as a duplicate of bug 1532588 *** |