Bug 1179172 (plasma-workspace)
| Summary: | Review Request: plasma-workspace - Plasma workspace applications and applets | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Grulich <jgrulich> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-20 13:43:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1135103, 1179173 | ||
|
Description
Jan Grulich
2015-01-06 11:05:46 UTC
1. SHOULD omit "5" from pkg Summary , ie
Summary: Plasma Desktop
less worries when/if Plasma 6 appears, or maybe just not worry that far ahead :)
sources: ok
8a01835179b25e3a7ff644fd7e52ec96 plasma-workspace-5.1.2.tar.xz
2. SHOULD drop %config here
%config %{_sysconfdir}/xdg/*.knsrc
%config %{_sysconfdir}/xdg/autostart/*.desktop
stuff under /etc/xdg is generally not meant for %config really
3. SHOULD move these to main pkg (from -devel):
%{_datadir}/dbus-1/interfaces/*.xml
scriptlets: NOT ok
4. MUST validate application .desktop files
%{_datadir}/applications/*.desktop
macros: ok
stuff to look into post-review (not review blockers):
* SHOULD be owned by kde-settings instead, but can deal with that post-review
%config %{_sysconfdir}/pam.d/kde
* don't hard-code Requires: sddm , and then probably subpkg or own parent dirs of: %{_datadir}/sddm/themes/breeze
Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-workspace.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-workspace-5.1.2-3.fc21.src.rpm Description: Plasma workspace applications and applets - Omit "5" from pkg summary - Drop config macro for files installed to /etc/xdg - Move /usr/share/dbus-1/interfaces/*.xml stuff to main package - Validate .desktop files looks good, APPROVED. New Package SCM Request ======================= Package Name: plasma-workspace Short Description: Plasma workspace applications and applets Upstream URL: https://projects.kde.org/projects/kde/workspace/plasma-workspace Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f20 f21 InitialCC: Git done (by process-git-requests). Imported |