Bug 1179173 (plasma-desktop)
| Summary: | Review Request: plasma-desktop - Plasma Desktop | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jan Grulich <jgrulich> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | kevin, package-review, rdieter |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-01-20 13:43:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1179172 | ||
| Bug Blocks: | 1135103 | ||
|
Description
Jan Grulich
2015-01-06 11:10:36 UTC
sources: ok
cd5dbce577c175cb33008702400d5598 plasma-desktop-5.1.2.tar.xz
naming: ok (Mostly)
1. SHOULD omit "5" from pkg Summary , ie
Summary: Plasma Desktop
less worries when/if Plasma 6 appears, or maybe just not worry that far ahead :)
scriptlets: NOT ok
2. MUST add icon-cache scriptlets due to
%{_datadir}/icons/*/*/*/*
3. MUST validate application .desktop files
%{_datadir}/applications/*.desktop
macros: ok
I'll review relevant runtime deps from kde-workspace, and whether any/all should be added here or not, but that's not a review blocker either.
license: NOT ok
4. there seems to be GPLv2-only bit:
kcms/componentchooser
the rest is fairly GPLv2 or GPLv3 (or upgradable from LGPL), I guess we'll have to go with:
# kcms/componentchooser is GPLv2 only
# rest is GPLv2 or GPLv3 (or upgradable from LGPL)
License: GPLv2 and (GPLv2 or GPLv3)
Spec URL: https://jgrulich.fedorapeople.org/plasma5/plasma-desktop.spec SRPM URL: https://jgrulich.fedorapeople.org/plasma5/plasma-desktop-5.1.2-3.fc21.src.rpm Description: Plasma Desktop - Omit "5" from pkg summary - Add icon cache scriptlets - Validate application .desktop files - Fixed license license tag is not quite right, License: License: GPLv2 and (GPLv2 or GPLv3) but that's cosmetic, and can be fixed post-review easy enough (please add the .spec comment from comment #1 too) APPROVED. New Package SCM Request ======================= Package Name: plasma-desktop Short Description: Plasma desktop Upstream URL: https://projects.kde.org/projects/kde/workspace/plasma-desktop Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl Branches: f21 InitialCC: Git done (by process-git-requests). |