Bug 1179175

Summary: gluster vol set testvol features.uss command accepts invalid random values
Product: [Community] GlusterFS Reporter: Gaurav Kumar Garg <ggarg>
Component: glusterdAssignee: Gaurav Kumar Garg <ggarg>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: mainlineCC: ashah, bugs, gluster-bugs, rjoseph, smohan, storage-qa-internal
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: glusterfs-3.7.0 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1161111 Environment:
Last Closed: 2015-05-14 17:28:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1177911    
Bug Blocks: 1161111    

Comment 1 Anand Avati 2015-01-06 11:41:22 UTC
REVIEW: http://review.gluster.org/9395 (glusterd: option features.uss should accept only boolean value) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2015-01-08 06:48:36 UTC
REVIEW: http://review.gluster.org/9395 (glusterd: option features.uss should accept only boolean value) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2015-01-19 05:12:27 UTC
REVIEW: http://review.gluster.org/9395 (glusterd: option features.uss should accept only boolean value) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 4 Anand Avati 2015-01-19 06:26:36 UTC
REVIEW: http://review.gluster.org/9395 (glusterd: option features.uss should accept only boolean value) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Anand Avati 2015-01-20 04:28:39 UTC
COMMIT: http://review.gluster.org/9395 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 1ee8ce725f0e70f45419aa0e2f4d85db7223d766
Author: GauravKumarGarg <ggarg>
Date:   Tue Jan 6 16:58:38 2015 +0530

    glusterd: option features.uss should accept only boolean value
    
    "features.uss" with a non-boolean value gets set in the volume option
    table because of which subsequent volume set operation fails since
    features.uss does not contain a valid boolean value.
    
    Fix is not to allow a non-boolean value to get set in the volume option
    table. "features.uss" option should have validation function "validate_uss"
    which validate the input value given by user.
    
    Change-Id: I4a212f876627a4979715183b0d488fd69095f193
    BUG: 1179175
    Signed-off-by: ggarg <ggarg>
    Reviewed-on: http://review.gluster.org/9395
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 6 Niels de Vos 2015-05-14 17:28:50 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:35:47 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:38:09 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:45:25 UTC
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user