Bug 1179217 (kf5-baloo)

Summary:	Review Request: kf5-baloo - A Tier 3 KDE Frameworks 5 module that provides indexing and search functionality
Product:	[Fedora] Fedora	Reporter:	Jan Grulich <jgrulich>
Component:	Package Review	Assignee:	Rex Dieter <rdieter>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	kevin, package-review, rdieter
Target Milestone:	---	Flags:	rdieter: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-01-20 13:43:33 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1135103

Description Jan Grulich 2015-01-06 12:59:24 UTC

Spec URL: https://jgrulich.fedorapeople.org/plasma5/kf5-baloo.spec
SRPM URL: https://jgrulich.fedorapeople.org/plasma5/kf5-baloo-5.1.2-2.fc21.src.rpm
Description: A Tier 3 KDE Frameworks 5 module that provides indexing and search functionality
Fedora Account System Username: jgrulich

Comment 1 Rex Dieter 2015-01-06 18:03:26 UTC

1.  this part in -devel
%{_kf5_datadir}/dbus-1/interfaces/org.kde.baloo.file.indexer.xml
looks like it SHOULD be in -file subpkg instead

naming: ok

sources: ok
a8ddea44b89176530b6598231ff89c43  baloo-5.1.2.tar.xz


2. SHOULD consider dropping -tools subpkg, these aren't big so why split them out?

scriptlets: NOT ok

3. main pkg contains
%{_kf5_datadir}/icons/hicolor/*/apps/baloo.png
MUST add icon cache scriptlets

macros: ok

4.  -devel subpkg uses deprecated Group: tag, SHOULD remove it

Comment 2 Jan Grulich 2015-01-07 10:05:13 UTC

Spec URL: https://jgrulich.fedorapeople.org/plasma5/kf5-baloo.spec
SRPM URL: https://jgrulich.fedorapeople.org/plasma5/kf5-baloo-5.1.2-3.fc21.src.rpm

- Drop -file subpkg
- Add icon cache scriptlets
- Remove deprecated Group: tag
- Move org.kde.baloo.file.indexer.xml to -file subpkg

Comment 3 Rex Dieter 2015-01-07 14:30:45 UTC

thanks, APPROVED


5. SHOULD fix changelog s/Drop -file subpkg/Drop -tools subpkg/  :)

Comment 4 Jan Grulich 2015-01-08 08:56:55 UTC

New Package SCM Request
=======================
Package Name: kf5-baloo
Short Description: A Tier 3 KDE Frameworks 5 module that provides indexing and search functionality
Upstream URL: https://projects.kde.org/projects/kde/kdelibs/baloo
Owners: group::kde-sig rdieter kkofler dvratil than jgrulich ltinkl
Branches: f20 f21
InitialCC:

Comment 5 Gwyn Ciesla 2015-01-08 13:55:17 UTC

Git done (by process-git-requests).