Bug 1179275

Summary:	Utilize system-wide crypto-policies
Product:	[Fedora] Fedora	Reporter:	Nikos Mavrogiannopoulos <nmavrogi>
Component:	aqbanking	Assignee:	Bill Nottingham <notting>
Status:	CLOSED WORKSFORME	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	21	CC:	notting, rdieter, redhat-bugzilla
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-30 03:40:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1179209

Description Nikos Mavrogiannopoulos 2015-01-06 14:24:41 UTC

Please convert to use the system's crypto policy for SSL and TLS:
https://fedoraproject.org/wiki/Packaging:CryptoPolicies

If this program is compiled against gnutls, change the default priority string to be "@SYSTEM" or to use gnutls_set_default_priority().

If this program is compiled against openssl, and there is no default cipher list specified, you don't need to modify it. Otherwise replace the default cipher list with "PROFILE=SYSTEM".

In both cases please verify that the application uses the system's crypto policies.

If the package is already using the system-wide crypto policies, or it does not use SSL or TLS, no action is required, the bug can simply be closed.

Comment 1 Robert Scheck 2015-03-23 21:47:31 UTC

In latest aqbanking-5.5.1-1.fc23 package neither SSL_CTX_set_cipher_list nor
gnutls_priority_set_direct, gnutls_priority_init or gnutls_set_default_priority
are present. According to the spec file neither OpenSSL nor GnuTLS are directly
consumed, but xmlsec1-gnutls-devel.

Looking however to gwenhywfar, gnutls_set_default_priority() is being called
before gnutls_protocol_set_priority().

Comment 2 Nikos Mavrogiannopoulos 2015-03-24 07:16:32 UTC

(In reply to Robert Scheck from comment #1)

> Looking however to gwenhywfar, gnutls_set_default_priority() is being called
> before gnutls_protocol_set_priority().

In that case, the gnutls_set_default_priority() is not used at all. It is overriden by the second call, so you may need to apply the default policies by removing the second call, or by the other methods indicated.

Comment 3 Bill Nottingham 2015-03-25 02:10:21 UTC

From following the code, AFAICT (removing lots of extraneous lines)

...
#if 1 /* old code */
  rv=gnutls_set_default_priority(xio->session);
  if (rv) {
    gnutls_deinit(xio->session);
    return GWEN_ERROR_GENERIC;
  }

  /* possibly force protocol priority */
  if (lflags & GWEN_SYNCIO_TLS_FLAGS_FORCE_SSL_V3) {
    const int proto_prio[2] = { GNUTLS_SSL3, 0 };

    rv=gnutls_protocol_set_priority(xio->session, proto_prio);
    if (rv) {
      gnutls_deinit(xio->session);
      return GWEN_ERROR_GENERIC;
    }
  }
#else /* new code */
... lots of other stuff ...
#endif

So, for now, it looks like we do the right thing out of the box. GWEN_SYNCIO_TLS_FLAGS_FORCE_SSL_V3 is a caller-set flag, that is plumbed through aqbanking as an account specific setting. It's not on by default.

Comment 4 Bill Nottingham 2015-06-30 03:40:54 UTC

Closing as WORKSFORME - AFAICT it's doing the right thing.