Bug 1179318

Summary:	Utilize system-wide crypto-policies
Product:	[Fedora] Fedora	Reporter:	Nikos Mavrogiannopoulos <nmavrogi>
Component:	libvncserver	Assignee:	Simone Caronni <negativo17>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	negativo17, ppisar, rdieter
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libvncserver-0.9.10-3.fc23 libvncserver-0.9.10-3.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-12-28 22:56:31 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1179209

Description Nikos Mavrogiannopoulos 2015-01-06 14:58:42 UTC

Please convert this application to use the system's crypto policy for SSL and TLS:
https://fedoraproject.org/wiki/Packaging:CryptoPolicies

If this program is compiled against gnutls, change the default priority string to be "@SYSTEM" or to use gnutls_set_default_priority().

If this program is compiled against openssl, and there is no default cipher list specified, you don't need to modify it. Otherwise replace the default cipher list with "PROFILE=SYSTEM".

In both cases please verify that the application uses the system's crypto policies.

If the package is already using the system-wide crypto policies, or it does not use SSL or TLS, no action is required, the bug can simply be closed.

Comment 1 Nikos Mavrogiannopoulos 2015-07-09 15:01:00 UTC

Hello, what is the blocker for that issue?

Comment 2 Rex Dieter 2015-07-11 14:43:05 UTC

No strict blocker, mostly a lack of time to implement/verify this (so far).

Comment 3 Simone Caronni 2015-12-12 13:51:11 UTC

I just updated libvncserver to the official 0.9.10 release and applied a patch [1] for this issue. Build is libvncserver-0.9.10-2 [2].

I'm no programmer, so please have a check before I submit the update. I'm not sure about rfbAnonTLSPriority.

[1] http://pkgs.fedoraproject.org/cgit/libvncserver.git/tree/LibVNCServer-0.9.10-system-crypto-policy.patch
[2] http://koji.fedoraproject.org/koji/packageinfo?packageID=5744

Thanks,
--Simone

Comment 4 Nikos Mavrogiannopoulos 2015-12-14 09:10:05 UTC

Hi,
 I am not sure if rfbTLSPriority and rfbAnonTLSPriority are used anywhere, but if yes, I'd use that:
+static const char *rfbTLSPriority = "@SYSTEM:+SRP";
+static const char *rfbAnonTLSPriority= "@SYSTEM:+ANON-DH";

Comment 5 Simone Caronni 2015-12-17 20:28:20 UTC

Seems legit. Thanks, I will leave it in testing for a couple of weeks.

Comment 6 Fedora Update System 2015-12-17 20:29:20 UTC

libvncserver-0.9.10-3.fc23 has been submitted as an update to Fedora 23. https://bodhi.fedoraproject.org/updates/FEDORA-2015-b7c1fd61e1

Comment 7 Fedora Update System 2015-12-18 11:26:19 UTC

libvncserver-0.9.10-3.fc22 has been pushed to the Fedora 22 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libvncserver'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-9373473258

Comment 8 Fedora Update System 2015-12-18 11:55:00 UTC

libvncserver-0.9.10-3.fc23 has been pushed to the Fedora 23 testing repository. If problems still persist, please make note of it in this bug report.
If you want to test the update, you can install it with
$ su -c 'dnf --enablerepo=updates-testing update libvncserver'
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2015-b7c1fd61e1

Comment 9 Fedora Update System 2015-12-28 22:56:28 UTC

libvncserver-0.9.10-3.fc23 has been pushed to the Fedora 23 stable repository. If problems still persist, please make note of it in this bug report.

Comment 10 Fedora Update System 2016-01-08 03:28:08 UTC

libvncserver-0.9.10-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report.