Bug 1180004

+++ This bug was initially created as a clone of Bug #1171002 +++

Description of problem:
Moving gear from non-district node to district node will fail when set USE_PREDICTABLE_GEAR_UUIDS=true in broker.conf.

Version-Release number of selected component (if applicable):
ose2.2/2014-12-02.3

How reproducible:
Always

Steps to Reproduce:
1.Prepare env with 2 small gear size nodes, node1 in district, node2 not in district. Set USE_PREDICTABLE_GEAR_UUIDS=true in broker.conf.
2.Create app on node2(not in district). 
# rhc app create pl1 perl-5.10
Make sure gear's uid available in district.
# id -u hanli1dom-pl1-1
1001
3.Move app gear from node2 to node1.
# oo-admin-move --gear_uuid hanli1dom-pl1-1 -i node1.ose22-move.com.cn


Actual results:
3.Moving failed.
# oo-admin-move --gear_uuid hanli1dom-pl1-1 -i node1.ose22-move.com.cn
URL: http://pl1-hanli1dom.ose22-20141201.com.cn
Login: hanli1
App UUID: 548166218e45f07eb8000016
Gear UUID: 548166218e45f07eb8000016
/opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/base.rb:145:in `rescue in validate_input_argument': Cannot validate input gear_uuid: value should match ^[a-zA-Z0-9]+$ (MCollective::DDLValidationError)
	from /opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/base.rb:126:in `validate_input_argument'
	from /opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/agentddl.rb:194:in `block in validate_rpc_request'
	from /opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/agentddl.rb:186:in `each'
	from /opt/rh/ruby193/root/usr/share/ruby/mcollective/ddl/agentddl.rb:186:in `validate_rpc_request'
	from /opt/rh/ruby193/root/usr/share/ruby/mcollective/rpc/client.rb:169:in `validate_request'
	from /opt/rh/ruby193/root/usr/share/ruby/mcollective/rpc/client.rb:240:in `method_missing'
	from /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-msg-broker-mcollective-1.31.1.1/lib/openshift/mcollective_application_container_proxy.rb:2873:in `block in get_gear_uid'
	from /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-msg-broker-mcollective-1.31.1.1/lib/openshift/mcollective_application_container_proxy.rb:2440:in `rpc_exec'
	from /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-msg-broker-mcollective-1.31.1.1/lib/openshift/mcollective_application_container_proxy.rb:2872:in `get_gear_uid'
	from /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-msg-broker-mcollective-1.31.1.1/lib/openshift/mcollective_application_container_proxy.rb:1947:in `move_gear'
	from /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-msg-broker-mcollective-1.31.1.1/lib/openshift/mcollective_application_container_proxy.rb:1937:in `block in move_gear_secure'
	from /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-controller-1.32.3.2/app/models/lock.rb:62:in `run_in_app_lock'
	from /opt/rh/ruby193/root/usr/share/gems/gems/openshift-origin-msg-broker-mcollective-1.31.1.1/lib/openshift/mcollective_application_container_proxy.rb:1934:in `move_gear_secure'
	from /usr/sbin/oo-admin-move:114:in `<main>'


Expected results:
3.Should move gear successfully.

Additional info:
Moving gear between districts or moving gear between nodes in the same district work well when USE_PREDICTABLE_GEAR_UUIDS=true.
If set USE_PREDICTABLE_GEAR_UUIDS=false in broker.conf, repeat the step 2 and 3, move will succeed.

--- Additional comment from Luke Meyer on 2014-12-05 21:28:52 CST ---

Another validation to correct. Thank you for catching this.

--- Additional comment from Luke Meyer on 2014-12-06 04:43:36 CST ---

https://github.com/openshift/origin-server/pull/6001

--- Additional comment from openshift-github-bot on 2014-12-06 04:55:32 CST ---

Commit pushed to master at https://github.com/openshift/origin-server

https://github.com/openshift/origin-server/commit/544c81e62f9b1e2eb9cb06cb064a53844a7c7c34
openshift.ddl: fix gear UUID regexes

Bug 1171002 - Moving gear from non-district node to district node will
fail when set USE_PREDICTABLE_GEAR_UUIDS=true
https://bugzilla.redhat.com/show_bug.cgi?id=1171002