Bug 1180132
| Summary: | Review Request: perl-File-Share - Extend File::ShareDir to local libraries | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Petr Šabata <psabata> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-File-Share-0.25-1.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-14 11:39:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1178391 | ||
|
Description
Petr Šabata
2015-01-08 12:59:59 UTC
URL and Source0 are usable. Ok.
Source archive is original (SHA-256: 8e9d256e0ac4384228384b4ad2a57819a163edb39f20988ed5c1318c01407070). Ok.
Summary verified from lib/File/Share.pod. Ok.
Description verified from lib/File/Share.pod. Ok.
License verified from lib/File/Share.pod, README, LICENSE. Ok.
No XS code, noarch BuildArch is Ok.
TODO: Constrain `perl(File::ShareDir)' dependency with `>= 1.03' version (META.json:37).
Test::Pod is not used. Ok.
All tests pass. Ok.
$ rpmlint perl-File-Share.spec ../SRPMS/perl-File-Share-0.25-1.fc22.src.rpm ../RPMS/noarch/perl-File-Share-0.25-1.fc22.noarch.rpm
perl-File-Share.src: W: spelling-error Summary(en_US) ShareDir -> Share Dir, Share-Dir, Reddish
perl-File-Share.src: W: spelling-error %description -l en_US ShareDir -> Share Dir, Share-Dir, Reddish
perl-File-Share.src: W: spelling-error %description -l en_US dir -> deer, rid, Dir
perl-File-Share.noarch: W: spelling-error Summary(en_US) ShareDir -> Share Dir, Share-Dir, Reddish
perl-File-Share.noarch: W: spelling-error %description -l en_US ShareDir -> Share Dir, Share-Dir, Reddish
perl-File-Share.noarch: W: spelling-error %description -l en_US dir -> deer, rid, Dir
2 packages and 1 specfiles checked; 0 errors, 6 warnings.
rpmlint is Ok.
$ rpm -q -lv -p ../RPMS/noarch/perl-File-Share-0.25-1.fc22.noarch.rpm
drwxr-xr-x 2 root root 0 Jan 8 14:35 /usr/share/doc/perl-File-Share
-rw-r--r-- 1 root root 1280 Aug 21 20:59 /usr/share/doc/perl-File-Share/CONTRIBUTING
-rw-r--r-- 1 root root 1351 Aug 21 20:59 /usr/share/doc/perl-File-Share/Changes
-rw-r--r-- 1 root root 1712 Aug 21 20:59 /usr/share/doc/perl-File-Share/README
drwxr-xr-x 2 root root 0 Jan 8 14:35 /usr/share/licenses/perl-File-Share
-rw-r--r-- 1 root root 18350 Aug 21 20:59 /usr/share/licenses/perl-File-Share/LICENSE
-rw-r--r-- 1 root root 2031 Jan 8 14:34 /usr/share/man/man3/File::Share.3pm.gz
drwxr-xr-x 2 root root 0 Jan 8 14:34 /usr/share/perl5/vendor_perl/File
-rw-r--r-- 1 root root 1027 Aug 21 20:59 /usr/share/perl5/vendor_perl/File/Share.pm
-rw-r--r-- 1 root root 2169 Aug 21 20:59 /usr/share/perl5/vendor_perl/File/Share.pod
File permissions and layout are Ok.
$ rpm -q --requires -p ../RPMS/noarch/perl-File-Share-0.25-1.fc22.noarch.rpm | sort -f | uniq -c
1 perl(:MODULE_COMPAT_5.20.1)
1 perl(base)
1 perl(Cwd)
1 perl(Exporter)
1 perl(File::ShareDir)
1 perl(File::Spec)
1 perl(strict)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p ../RPMS/noarch/perl-File-Share-0.25-1.fc22.noarch.rpm | sort -f | uniq -c
1 perl(File::Share) = 0.25
1 perl-File-Share = 0.25-1.fc22
Binary provides are Ok.
$ resolvedeps rawhide ../RPMS/noarch/perl-File-Share-0.25-1.fc22.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F22 (http://koji.fedoraproject.org/koji/taskinfo?taskID=8559017). Ok.
Package is in line with Fedora and Perl packaging guidelines.
Please consider fixing all `TODO' items before building this package.
Resolution: Package APPROVED.
New Package SCM Request ======================= Package Name: perl-File-Share Short Description: Extend File::ShareDir to local libraries Upstream URL: http://search.cpan.org/dist/File-Share/ Owners: psabata jplesnik ppisar Branches: f21 InitialCC: perl-sig Git done (by process-git-requests). Thanks, both. |