Bug 1180814

Issues:
=======
- glib-compile-schemas is run in %postun and %posttrans if package has
  *.gschema.xml files.
  Note: gschema file(s) in gnome-shell-extension-simple-dock
  See:
  http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#GSettings_Schema

Otherwise looks good.

No rpmlint output, that does not happen often.

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/gnome-shell-extension-simple-dock.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/gnome-shell-extension-simple-dock-0.1-20141014git39b8503.fc21.2.src.rpm


Changelog:
- 0.1-20141014git39b8503.2
- Add %%postun and %%posttrans

Koji build from scrath:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8788351

Spec URL: https://williamjmorenor.fedorapeople.org/rpmdev/gnome-shell-extension-simple-dock.spec
SRPM URL: https://williamjmorenor.fedorapeople.org/rpmdev/gnome-shell-extension-simple-dock-0.1-20141014git39b8503.fc21.2.noarch.rpm


Changelog:
- 0.1-20141014git39b8503.2
- Add %%postun and %%posttrans

Koji build from scrath:
http://koji.fedoraproject.org/koji/taskinfo?taskID=8788351

========================
Just fixing the srpm url
========================

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses found:
     "Unknown or generated". 12 files have unknown license. Detailed output of
     licensecheck in /var/tmp/review-gnome-shell-extension-simple-
     dock/licensecheck.txt
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/share/gnome-shell/extensions
Please co-own this directory. Otherwise a dependency on gnome-shell-extension-common would work, but if the dependency is not needed otherwise, co-ownership is a better option.

[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: glib-compile-schemas is run in %postun and %posttrans if package has
     *.gschema.xml files.
     Note: gschema file(s) in gnome-shell-extension-simple-dock
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: No rpmlint messages.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package do not use a name that already exist
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Scriptlets must be sane, if used.
[ ]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed files.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: gnome-shell-extension-simple-dock-0.1-20141014git39b8503.fc22.2.noarch.rpm
          gnome-shell-extension-simple-dock-0.1-20141014git39b8503.fc22.2.src.rpm
2 packages and 0 specfiles checked; 0 errors, 0 warnings.




Rpmlint (installed packages)
----------------------------
Cannot parse rpmlint output:


Requires
--------
gnome-shell-extension-simple-dock (rpmlib, GLIBC filtered):
    /bin/bash
    /bin/sh
    gnome-tweak-tool



Provides
--------
gnome-shell-extension-simple-dock:
    gnome-shell-extension-simple-dock



Source checksums
----------------
https://github.com/optimisme/gnome-shell-simple-dock/archive/39b85035d252b62c69c3c5d457f0baf8c6a4d8d2/gnome-shell-simple-dock-39b85035d252b62c69c3c5d457f0baf8c6a4d8d2.tar.gz :
  CHECKSUM(SHA256) this package     : 9302a20082f83da38594989db3d040c2807c4d778c718d77f520cd173a95d404
  CHECKSUM(SHA256) upstream package : 9302a20082f83da38594989db3d040c2807c4d778c718d77f520cd173a95d404


Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
Command line :/usr/bin/fedora-review -n gnome-shell-extension-simple-dock
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Shell-api
Disabled plugins: Java, C/C++, Python, fonts, SugarActivity, Ocaml, Perl, Haskell, R, PHP, Ruby
Disabled flags: EXARCH, EPEL5, BATCH, DISTTAG

Package is APPROVED.

New Package SCM Request
=======================
Package Name: gnome-shell-extension-simple-dock
Short Description: Simple Dock for the Gnome Shell desktop
Upstream URL: https://github.com/optimisme/gnome-shell-simple-dock
Owners: williamjmorenor
Branches: F21 Master
InitialCC: williamjmorenor

Git done (by process-git-requests).

gnome-shell-extension-simple-dock-0.1-20141014git39b8503.fc21.2 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/gnome-shell-extension-simple-dock-0.1-20141014git39b8503.fc21.2

gnome-shell-extension-simple-dock-0.1-20141014git39b8503.fc21.2 has been pushed to the Fedora 21 testing repository.

gnome-shell-extension-simple-dock-0.1-20141014git39b8503.fc21.2 has been pushed to the Fedora 21 stable repository.