Bug 1180851

Present in 2.6.7 source code installation download from project home.

Confirmed in F22

Also there in F23

Hi,

I have tested with latest svn code, where the same issue was triggered on my machine. So on a casual glance, it seems like there is a dependence on usb_device_c declared in usb_common in usb_uhci, and has RTLD_LAZY resolve only works for functions and not variables, it doesn't help here. So I have changed the sequence of loading wrt usb_uhci and usb_common, so that usb_common gets loaded first. However if for any reason usb_uhci doesn't load and if no other usb controllers are also loaded, then I take care of unloading usb_common, so that the old behaviour wrt usb_common is not changed, even thou location of loading of same is changed by my patch.

And this seems to solve the problem. However currently I am looking at bochs to help with some experimentation with a bootloader, so I haven't explicitly checked the usb logic, after my change, but logically don't see any reason why there should be a problem.


--- iodev/devices.cc	(revision 12882)
+++ iodev/devices.cc	(working copy)
@@ -180,6 +180,7 @@
     PLUG_load_plugin(pci, PLUGTYPE_CORE);
     PLUG_load_plugin(pci2isa, PLUGTYPE_CORE);
 #if BX_SUPPORT_PCIUSB
+    PLUG_load_plugin(usb_common, PLUGTYPE_CORE);
     if (chipset == BX_PCI_CHIPSET_I440FX) {
       // UHCI is a part of the PIIX3, so load / enable it
       if (!PLUG_device_present("usb_uhci")) {
@@ -188,8 +189,10 @@
       SIM->get_param_bool(BXPN_UHCI_ENABLED)->set(1);
     }
     usb_enabled = is_usb_enabled();
-    if (usb_enabled)
-      PLUG_load_plugin(usb_common, PLUGTYPE_CORE);
+    if (!usb_enabled) {
+      PLUG_unload_plugin(usb_common);
+      BX_PANIC(("Bochs has failed to load usb_uhci???"));
+    }
 #endif
     if (chipset == BX_PCI_CHIPSET_I440FX) {
       PLUG_load_plugin(acpi, PLUGTYPE_STANDARD);

I have the same problem with current F24.

Cannot reproduce with version 2.6.8 compiled from source with:
]$ configure --enable-gdb-stub

Issue persists with bochs-2.6.2-10.fc24.x86_64.

When I build the current SVN checkout with the portion of the above patch that still applies, it fixes the USB issue but still crashes.  If anyone would like to take a look, I've put builds here:

https://fedorapeople.org/~limb/bochs/

(In reply to Jon Ciesla from comment #8)
> When I build the current SVN checkout with the portion of the above patch
> that still applies, it fixes the USB issue but still crashes.  If anyone
> would like to take a look, I've put builds here:
> 
> https://fedorapeople.org/~limb/bochs/

 %install
 rm -rf $RPM_BUILD_ROOT _installed-docs
 make install DESTDIR=$RPM_BUILD_ROOT
 rm -rf $RPM_BUILD_ROOT%{_prefix}/share/bochs/VGABIOS*  <===

As VGABIOS* had been deleted, bochs hang for me. After package up "%{_datadir}/bochs/VGABIOS*", bochs works for me as expected. But bochs-debugger and bochs-gdb failed. Anyway, thanks for the scratch RPMs.

Updated builds in https://fedorapeople.org/~limb/bochs/

bochs-2.6.9-1.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6e54134f4c

bochs-2.6.9-1.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-1b0a9a2184

bochs-2.6.9-1.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-5e9ae14f38

bochs-2.6.9-1.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-5e9ae14f38

bochs-2.6.9-1.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6e54134f4c

bochs-2.6.9-1.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-1b0a9a2184

bochs-2.6.9-2.fc26 has been submitted as an update to Fedora 26. https://bodhi.fedoraproject.org/updates/FEDORA-2017-654016e876

bochs-2.6.9-2.fc25 has been submitted as an update to Fedora 25. https://bodhi.fedoraproject.org/updates/FEDORA-2017-39519fc6b4

bochs-2.6.9-2.fc24 has been submitted as an update to Fedora 24. https://bodhi.fedoraproject.org/updates/FEDORA-2017-6a17b108d7

bochs-2.6.9-2.fc25 has been pushed to the Fedora 25 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-39519fc6b4

bochs-2.6.9-2.fc26 has been pushed to the Fedora 26 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-654016e876

bochs-2.6.9-2.fc24 has been pushed to the Fedora 24 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2017-6a17b108d7

bochs-2.6.9-2.fc26 has been pushed to the Fedora 26 stable repository. If problems still persist, please make note of it in this bug report.

bochs-2.6.9-2.fc25 has been pushed to the Fedora 25 stable repository. If problems still persist, please make note of it in this bug report.

bochs-2.6.9-2.fc24 has been pushed to the Fedora 24 stable repository. If problems still persist, please make note of it in this bug report.