Bug 1180860

Summary: New default theme in Fedora 21 makes vim spell-check unreadable
Product: [Fedora] Fedora Reporter: Isaac Lenton <isaac>
Component: vimAssignee: Karsten Hopp <karsten>
Status: CLOSED NEXTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 21CC: ignatenko, isaac, karsten, moshima.web
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Unspecified   
Whiteboard:
Fixed In Version: 7.4.827-1.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-09-22 08:36:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Proposed patch
none
Default vim highlighting theme based on gnome-terminal theme none

Description Isaac Lenton 2015-01-11 09:24:23 UTC 
Description of problem:  After updating to Fedora 21 and opening a text file with vim in gnome-terminal with `:set spell` enabled I am unable to read text highlighted as misspelled or uncommon spelling.  This is due to the new default theme for gnome-terminal.

Version-Release number of selected component (if applicable):
vim-enhanced.x86_64                  2:7.4.475-2.fc21                  installed

Steps to Reproduce:
1. Set gnome-terminal to 'use colours from system theme'
2. Open vim, enable spell checking `:set spell`
3. Type misspelled words (asdf) and uncommon word (color for en_au)

Actual results:
Unable to read words highlighted as misspelled or uncommon.

Expected results:
Highlighting colours of misspelled and uncommon words should not clash with the default terminal theme.

Additional info:
Perhaps this link might be useful: https://stackoverflow.com/questions/11279456/how-to-change-the-color-of-highlighted-misspelled-word
Comment 1 Isaac Lenton 2015-01-11 11:39:07 UTC 
This is also an issue for the default highlighting of search items.
Comment 2 Isaac Lenton 2015-01-11 12:25:44 UTC 
Created attachment 978755 [details]
Proposed patch

Adds `set background=dark` to the default vimrc.
Comment 3 Isaac Lenton 2015-02-18 15:02:04 UTC 
Created attachment 993154 [details]
Default vim highlighting theme based on gnome-terminal theme

Better version.  The `set background=light/dark` is now based on the user's settings in gnome-terminal.
Comment 4 Karsten Hopp 2015-09-22 08:36:00 UTC 
This is supposed to be fixed in vim-7.4.827-1.fc21, please update your vim packages. At the moment they are still in the updates-testing repo, but should be moved to f21-updates soon.

In the meantime the command 'yum --enablerepo updates-testing update vim' will update vim
Comment 5 Fedora Update System 2015-09-23 00:22:00 UTC 
vim-7.4.827-1.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report.