Bug 1181209

Summary:	Use systemd service status for run detection in S390 console
Product:	Red Hat Enterprise Linux 7	Reporter:	Martin Kolman <mkolman>
Component:	initial-setup	Assignee:	Martin Kolman <mkolman>
Status:	CLOSED ERRATA	QA Contact:	Release Test Team <release-test-team-automation>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.2	CC:	jstodola, mkolman
Target Milestone:	rc
Target Release:	---
Hardware:	s390x
OS:	Linux
Whiteboard:
Fixed In Version:	initial-setup-0.3.9.28-2	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 11:23:16 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Martin Kolman 2015-01-12 15:23:42 UTC

Description of problem:
In one of the s390 installation scenarios Initial setup is automatically launched by a special script on the first console loging after the installation. This script uses a configuration file even though it could just check if the Initial Setup systemd service is enabled. This introduces a special case that needs to be maintained to keep working, without bringing any benefits.

Version-Release number of selected component (if applicable):
0.3.9.21

How reproducible:
always

Actual results:
a special configuration file is used to check if Initial Setup should be run

Expected results:
the startup script just checks if the Initial setup systemd service is enabled

Comment 4 Jan Stodola 2015-08-17 10:22:05 UTC

Since systemd services are used now, I believe it is not necessary to create 
/etc/sysconfig/initial-setup in %post:

postinstall scriptlet (using /bin/sh):
if [ $1 -ne 2 -a ! -f /etc/sysconfig/initial-setup ]; then
  platform="$(arch)"
  if [ "$platform" = "s390" -o "$platform" = "s390x" ]; then
    echo "RUN_INITIAL_SETUP=YES" > /etc/sysconfig/initial-setup
  else
...

Moving to ASSIGNED

Comment 5 Martin Kolman 2015-08-25 11:26:01 UTC

(In reply to Jan Stodola from comment #4)
> Since systemd services are used now, I believe it is not necessary to create 
> /etc/sysconfig/initial-setup in %post:
> 
> postinstall scriptlet (using /bin/sh):
> if [ $1 -ne 2 -a ! -f /etc/sysconfig/initial-setup ]; then
>   platform="$(arch)"
>   if [ "$platform" = "s390" -o "$platform" = "s390x" ]; then
>     echo "RUN_INITIAL_SETUP=YES" > /etc/sysconfig/initial-setup
>   else
> ...
> 
> Moving to ASSIGNED
Good point! I've posted a patch removing /etc/sysconfig/initial-setup creation from the spec file for review.

Comment 7 Jan Stodola 2015-09-04 10:54:19 UTC

initial-setup starts based on the initial-setup systemd service status (enabled/disabled). Also /etc/sysconfig/initial-setup doesn't exist any more.

Tested with initial-setup-0.3.9.29-1.el7.

Moving to VERIFIED.

Comment 8 errata-xmlrpc 2015-11-19 11:23:16 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2334.html