Created attachment 979217[details]
Patch description included in the patch zip
A test patch created for DV 6.1.0.ER4 (EAP 6.3.1) to DV 6.1.0.ER5 (EAP 6.3.2) removes one module in the dv layer. When this patch is applied to a 6.1.0.ER4 server, the process succeeds and requests a restart of the server. Upon start-up, the server attempts to load the module.xml for the removed module in the dv layer overlay created for the patch, and throws an exception:
org.jboss.modules.xml.XmlPullParserException: Missing one or more required attributes: target-name (position: START_TAG seen ...xmlns="urn:jboss:module:1.2" name="org.jboss.netty" slot="main" />... @2:82)
It appears that the server is unable to parse the XML that was written by the patch applier. It should successfully load the file and then know the overlay says to drop that module.
The full log and patch description are attached.
This bug may now be affecting an actual patch, BZ-1213582 for DV 6.1.2.
Comment 6Alexey Loubyansky
2015-06-10 13:35:00 UTC
This is a bug (misprint) in org.jboss.modules.ModuleXmlParser.parseModuleAbsentContents(...). It requires target-name attribute for no reason.
I verified that the patching code produces valid module-absent content.
Alexey,
Thanks for looking into this.
Has a bug been filed with the broken component? Could you please set this bug's Depends On to include that bug please?
Comment 8Alexey Loubyansky
2015-06-16 12:14:32 UTC
After MODULES-209 has been fixed, the release of jboss-modules with the fix will have to make it into the next WildFly and EAP versions.
Comment 9JBoss JIRA Server
2015-06-16 12:17:23 UTC
David Lloyd <david.lloyd> updated the status of jira MODULES-209 to Resolved
Created attachment 979217 [details] Patch description included in the patch zip A test patch created for DV 6.1.0.ER4 (EAP 6.3.1) to DV 6.1.0.ER5 (EAP 6.3.2) removes one module in the dv layer. When this patch is applied to a 6.1.0.ER4 server, the process succeeds and requests a restart of the server. Upon start-up, the server attempts to load the module.xml for the removed module in the dv layer overlay created for the patch, and throws an exception: org.jboss.modules.xml.XmlPullParserException: Missing one or more required attributes: target-name (position: START_TAG seen ...xmlns="urn:jboss:module:1.2" name="org.jboss.netty" slot="main" />... @2:82) It appears that the server is unable to parse the XML that was written by the patch applier. It should successfully load the file and then know the overlay says to drop that module. The full log and patch description are attached.