Bug 1182490

Summary: Internal ec xattrs are allowed to be modified
Product: [Community] GlusterFS Reporter: Pranith Kumar K <pkarampu>
Component: disperseAssignee: Pranith Kumar K <pkarampu>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 3.6.1CC: bugs, lidi, rabhat
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: glusterfs-v3.6.3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1178688 Environment:
Last Closed: 2016-02-04 15:21:33 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1178688    
Bug Blocks: 1184460    

Description Pranith Kumar K 2015-01-15 09:30:18 UTC 
+++ This bug was initially created as a clone of Bug #1178688 +++

Description of problem:
Internal ec xattrs are allowed to be modified by the user, this can cause problems if the user modifies them in a wrong way by mistake.
root@pranithk-laptop - /mnt/fuse1 
15:34:11 :) ⚡ getfattr -d -m. -e hex /home/gfs/ec_?/a
getfattr: Removing leading '/' from absolute path names
# file: home/gfs/ec_2/a
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a66696c655f743a733000
trusted.ec.config=0x0000080301000200
trusted.ec.size=0x0000000000000004
trusted.ec.version=0x0000000000000001
trusted.gfid=0x5934895e011e4bc2aa0bae0b6d5148bb

# file: home/gfs/ec_3/a
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a66696c655f743a733000
trusted.ec.config=0x0000080301000200
trusted.ec.size=0x0000000000000004
trusted.ec.version=0x0000000000000001
trusted.gfid=0x5934895e011e4bc2aa0bae0b6d5148bb

# file: home/gfs/ec_4/a
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a66696c655f743a733000
trusted.ec.config=0x0000080301000200
trusted.ec.size=0x0000000000000004
trusted.ec.version=0x0000000000000001
trusted.gfid=0x5934895e011e4bc2aa0bae0b6d5148bb


root@pranithk-laptop - /mnt/fuse1 
15:34:36 :) ⚡ setfattr -n trusted.ec.size -v 0x0000000000000008 a

root@pranithk-laptop - /mnt/fuse1 
15:35:04 :) ⚡ getfattr -d -m. -e hex /home/gfs/ec_?/a
getfattr: Removing leading '/' from absolute path names
# file: home/gfs/ec_2/a
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a66696c655f743a733000
trusted.ec.config=0x0000080301000200
trusted.ec.size=0x0000000000000008
trusted.ec.version=0x0000000000000002
trusted.gfid=0x5934895e011e4bc2aa0bae0b6d5148bb

# file: home/gfs/ec_3/a
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a66696c655f743a733000
trusted.ec.config=0x0000080301000200
trusted.ec.size=0x0000000000000008
trusted.ec.version=0x0000000000000002
trusted.gfid=0x5934895e011e4bc2aa0bae0b6d5148bb

# file: home/gfs/ec_4/a
security.selinux=0x756e636f6e66696e65645f753a6f626a6563745f723a66696c655f743a733000
trusted.ec.config=0x0000080301000200
trusted.ec.size=0x0000000000000008
trusted.ec.version=0x0000000000000002
trusted.gfid=0x5934895e011e4bc2aa0bae0b6d5148bb


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

--- Additional comment from Anand Avati on 2015-01-05 09:21:30 EST ---

REVIEW: http://review.gluster.org/9385 (cluster/ec: Handle internal xattr get/set) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-01-05 09:25:42 EST ---

REVIEW: http://review.gluster.org/9385 (cluster/ec: Handle internal xattr get/set) posted (#2) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-01-06 02:07:37 EST ---

REVIEW: http://review.gluster.org/9385 (cluster/ec: Handle internal xattr get/set) posted (#3) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-01-07 05:18:19 EST ---

REVIEW: http://review.gluster.org/9385 (cluster/ec: Handle internal xattr get/set) posted (#4) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-01-08 02:02:25 EST ---

REVIEW: http://review.gluster.org/9385 (cluster/ec: Handle internal xattr get/set) posted (#5) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-01-08 04:44:22 EST ---

REVIEW: http://review.gluster.org/9385 (cluster/ec: Handle internal xattr get/set) posted (#6) for review on master by Pranith Kumar Karampuri (pkarampu)

--- Additional comment from Anand Avati on 2015-01-09 00:55:42 EST ---

COMMIT: http://review.gluster.org/9385 committed in master by Pranith Kumar Karampuri (pkarampu) 
------
commit 70dc47389cbe08238d8c216c51d49583154bd08a
Author: Pranith Kumar K <pkarampu>
Date:   Mon Jan 5 16:21:52 2015 +0530

    cluster/ec: Handle internal xattr get/set
    
    Problem:
    Internal xattrs of EC like trusted.ec.size/config/version
    can be modified by users and that can lead to misbehavior
    in EC.
    
    Fix:
    Don't let the user modify the xattrs. Hide these xattrs
    in getfattr outputs.
    
    Change-Id: I39cec96ae12826b506b496fda7da74201015fd75
    BUG: 1178688
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/9385
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Emmanuel Dreyfus <manu>
    Tested-by: Emmanuel Dreyfus <manu>
    Reviewed-by: Xavier Hernandez <xhernandez>
Comment 1 Anand Avati 2015-01-15 10:15:55 UTC 
REVIEW: http://review.gluster.org/9455 (cluster/ec: Handle internal xattr get/set) posted (#1) for review on release-3.6 by Pranith Kumar Karampuri (pkarampu)
Comment 2 Anand Avati 2015-01-15 11:08:37 UTC 
REVIEW: http://review.gluster.org/9455 (cluster/ec: Handle internal xattr get/set) posted (#2) for review on release-3.6 by Pranith Kumar Karampuri (pkarampu)
Comment 3 Anand Avati 2015-02-04 11:53:41 UTC 
COMMIT: http://review.gluster.org/9455 committed in release-3.6 by Raghavendra Bhat (raghavendra) 
------
commit 92ab560f73299a1d5faf43a1a90516baa2ba275b
Author: Pranith Kumar K <pkarampu>
Date:   Mon Jan 5 16:21:52 2015 +0530

    cluster/ec: Handle internal xattr get/set
    
            Backport of http://review.gluster.org/9385
    
    Problem:
    Internal xattrs of EC like trusted.ec.size/config/version
    can be modified by users and that can lead to misbehavior
    in EC.
    
    Fix:
    Don't let the user modify the xattrs. Hide these xattrs
    in getfattr outputs.
    
    BUG: 1182490
    Change-Id: Ie32ebb95ee67cabbb9488951097a517172b45bcf
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/9455
    Reviewed-by: Xavier Hernandez <xhernandez>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Raghavendra Bhat <raghavendra>
Comment 4 Kaushal 2016-02-04 15:21:33 UTC 
This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-v3.6.3, please open a new bug report.

glusterfs-v3.6.3 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] https://www.gluster.org/pipermail/gluster-users/2015-April/021669.html
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user