Bug 1182615
| Summary: | dnstop no IPv6 support - problem building with IPv6 support | ||
|---|---|---|---|
| Product: | [Fedora] Fedora EPEL | Reporter: | Kostas Zorbadelos <kzorba> |
| Component: | dnstop | Assignee: | Greg Bailey <gbailey> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | el6 | CC: | cse.cem+redhatbugz, denis, gbailey |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | dnstop-20140915-1.el6.1 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-05-10 20:37:57 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Kostas Zorbadelos
2015-01-15 14:56:22 UTC
It appears that "-DUSE_IPV6=1" is assigned to OPTFLAGS in the generated Makefile.
I think the problem is that the new value of CFLAGS as set in the dnstop.spec file no longer includes $OPTFLAGS, so USE_IPV6 is no longer defined.
I believe the following patch should suffice (in the el6 branch):
diff --git a/dnstop.spec b/dnstop.spec
index d6b361e..4a4dc3a 100644
--- a/dnstop.spec
+++ b/dnstop.spec
@@ -40,7 +40,7 @@ sed -i "s/CFLAGS=/CFLAGS?=/" Makefile
sed -i "s/LDFLAGS=/LDFLAGS?=/" Makefile
# hardening macro not in el6
export LDFLAGS="-Wl,-z,relro,-z,now"
-export CFLAGS="$RPM_OPT_FLAGS -fPIE -pie"
+export CFLAGS='${RPM_OPT_FLAGS} -fPIE -pie ${OPTFLAGS}'
make %{?_smp_mflags}
%install
(Note the single quotes vs. double quotes there...)
With this patch, the build is made with -DUSE_IPV6=1
I'm a Fedora package maintainer so if one of the maintainers would like to add me as a co-maintainer, I'm happy to check in this patch and push it through...
Not sure why I'm marked assignee on this. I don't use/maintain EL. @Greg, if you want to request maintainership in the database, and if it lets me, I'd be happy to approve you. Re: the patch, why the single quotes? Seems like we want the variables expanded, no? Thanks. (In reply to Conrad Meyer from comment #2) > Not sure why I'm marked assignee on this. I don't use/maintain EL. @Greg, if > you want to request maintainership in the database, and if it lets me, I'd > be happy to approve you. I requested commit access; it currently shows "Awaiting Review". I assume you should be able to approve since you're listed as the package administrator. > Re: the patch, why the single quotes? Seems like we want the variables > expanded, no? We do want the variables expanded, but not when it's evaluated by rpmbuild. Instead, $OPTFLAGS is expanded by make, and not by rpmbuild. And make is the process that has $OPTFLAGS defined (from reading the Makefile), not rpmbuild... thanks! You're approved, go wild! :-) (In reply to Conrad Meyer from comment #4) > You're approved, go wild! :-) thanks for your help! dnstop-20140915-1.el6.1 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/dnstop-20140915-1.el6.1 Package dnstop-20140915-1.el6.1: * should fix your issue, * was pushed to the Fedora EPEL 6 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=epel-testing dnstop-20140915-1.el6.1' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-EPEL-2015-5947/dnstop-20140915-1.el6.1 then log in and leave karma (feedback). dnstop-20140915-1.el6.1 has been pushed to the Fedora EPEL 6 stable repository. If problems still persist, please make note of it in this bug report. |