Bug 1183054

Summary: rpmlint throws couple of errors for RPM spec file
Product: [Community] GlusterFS Reporter: Lalatendu Mohanty <lmohanty>
Component: buildAssignee: Shwetha K Acharya <sacharya>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: mainlineCC: atumball, bugs, kkeithle, ndevos, rkothiya, sacharya, spamecha, vbellur, vpandey
Target Milestone: ---Keywords: StudentProject, Triaged
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-08-27 13:19:34 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lalatendu Mohanty 2015-01-16 15:10:40 UTC
Description of problem:

Running rpmlint on upstream master spec file giving two errors. Refer below for errors.

lmohanty@localhost glusterfs]$ rpmlint glusterfs.spec

glusterfs.spec:69: W: macro-in-comment %global
glusterfs.spec:207: W: unversioned-explicit-obsoletes hekafs
glusterfs.spec:210: W: unversioned-explicit-obsoletes %{name}-ufo
glusterfs.spec:427: W: non-standard-group Productivity/Clustering/HA
glusterfs.spec:432: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d
glusterfs.spec:703: W: macro-in-comment %post
glusterfs.spec:779: W: macro-in-comment %preun
glusterfs.spec:800: W: macro-in-comment %postun
glusterfs.spec:817: W: macro-in-comment %files
glusterfs.spec:948: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d/glusterfs
glusterfs.spec: W: invalid-url Source0: glusterfs-3.7dev.tar.gz
0 packages and 1 specfiles checked; 2 errors, 9 warnings.

Version-Release number of selected component (if applicable):

git tag on master branch: v3.7dev


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Vijay Bellur 2018-11-19 08:18:22 UTC
Behavior with glusterfs-6dev

glusterfs.spec:281: W: unversioned-explicit-obsoletes hekafs
glusterfs.spec:284: W: unversioned-explicit-obsoletes %{name}-ufo
glusterfs.spec:285: W: unversioned-explicit-obsoletes %{name}-ganesha
glusterfs.spec:553: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d
glusterfs.spec:1201: E: hardcoded-library-path in %{_prefix}/lib/ocf/resource.d/glusterfs
glusterfs.spec:1351: E: hardcoded-library-path in %{_prefix}/lib/firewalld/services/glusterfs.xml
glusterfs.spec: W: invalid-url Source0: glusterfs-6dev.tar.gz
0 packages and 1 specfiles checked; 3 errors, 4 warnings.

Comment 2 Worker Ant 2019-07-12 17:36:49 UTC
REVIEW: https://review.gluster.org/23039 (build: fix rpmlint errors and warnings in specfile) posted (#1) for review on master by Shwetha K Acharya

Comment 3 Worker Ant 2019-08-27 13:19:34 UTC
REVIEW: https://review.gluster.org/23039 (build: fix rpmlint warnings in specfile) merged (#5) on master by Amar Tumballi