Bug 1183228

Summary: Uninitialized and unalloced free
Product: [Fedora] Fedora Reporter: Honza Horak <hhorak>
Component: scl-utilsAssignee: Jan Zeleny <jzeleny>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 21CC: auchytil, bkabrda, jzeleny
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: scl-utils-2.0.1-2.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-01-30 04:28:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
gdb full backtrace
none
core dump
none
proposed patch none

Description Honza Horak 2015-01-17 12:43:55 UTC 
Description of problem:
Running `scl enable nonexisting whatever` crashed with core dump once to me. I'll attach core dump and backtrace.

Version-Release number of selected component (if applicable):
$> rpm -q scl-utils
scl-utils-2.0-2.fc21.x86_64

How reproducible:
sometimes, depending on content of uninitialized memory block

Steps to Reproduce:
1. scl enable nonexisting whatever
2. see the crash or at least look at the code ;)

Actual results:
freeing unallocated and uninitialized memory 

Expected results:
do it right

Additional info:
I really recommend running Coverity or other static analysis on this package.
Comment 1 Honza Horak 2015-01-17 12:44:50 UTC 
Created attachment 981007 [details]
gdb full backtrace
Comment 2 Honza Horak 2015-01-17 12:46:19 UTC 
Created attachment 981008 [details]
core dump
Comment 3 Honza Horak 2015-01-17 12:48:58 UTC 
Created attachment 981009 [details]
proposed patch

(without guarantee)
Comment 4 Fedora Update System 2015-01-21 08:26:58 UTC 
scl-utils-2.0.1-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/scl-utils-2.0.1-1.fc21
Comment 5 Fedora Update System 2015-01-21 08:27:18 UTC 
scl-utils-2.0.1-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/scl-utils-2.0.1-1.fc20
Comment 6 Fedora Update System 2015-01-21 23:04:43 UTC 
Package scl-utils-2.0.1-2.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing scl-utils-2.0.1-2.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-1006/scl-utils-2.0.1-2.fc21
then log in and leave karma (feedback).
Comment 7 Fedora Update System 2015-01-30 04:28:46 UTC 
scl-utils-2.0.1-2.fc20 has been pushed to the Fedora 20 stable repository.  If problems still persist, please make note of it in this bug report.
Comment 8 Fedora Update System 2015-01-30 04:44:17 UTC 
scl-utils-2.0.1-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.