Bug 1183265

Summary:	Sosreport doesn't collect conf.modules.d for httpd 2.4
Product:	Red Hat Enterprise Linux 7	Reporter:	Coty Sutherland <csutherl>
Component:	sos	Assignee:	Pavel Moravec <pmoravec>
Status:	CLOSED ERRATA	QA Contact:	David Kutálek <dkutalek>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.0	CC:	agk, dkutalek, isenfeld, pmoravec
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	sos-3.2-20.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 12:14:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Coty Sutherland 2015-01-17 22:16:15 UTC

Description of problem:
Since the update of httpd from 2.2 to 2.4 there is a new configuration directory (/etc/httpd/conf.modules.d) that is helpful to have which isn't included in the sosreport. This is nothing major, just a bit annoying to ask for a sosreport that gets almost everything you need, plus conf.modules.d.

I already submitted a PR and tested it to ensure it doesn't break anything on RHEL 6 and 7. The PR is here: 
https://github.com/sosreport/sos/pull/466

And here is the diff (super complex :)):

diff --git a/sos/plugins/apache.py b/sos/plugins/apache.py
index dc700cb..d21fc09 100644
--- a/sos/plugins/apache.py
+++ b/sos/plugins/apache.py
@@ -35,6 +35,7 @@ class RedHatApache(Apache, RedHatPlugin):
         self.add_copy_spec([
             "/etc/httpd/conf/httpd.conf",
             "/etc/httpd/conf.d/*.conf"
+            "/etc/httpd/conf.modules.d/*.conf"
         ])
 
         self.add_forbidden_path("/etc/httpd/conf/password.conf")

Currently awaiting acceptance upstream.

Comment 2 Shane Bradley 2015-01-19 20:44:46 UTC

*** Bug 1183266 has been marked as a duplicate of this bug. ***

Comment 3 Pavel Moravec 2015-02-06 15:33:15 UTC

(In reply to Coty Sutherland from comment #0)
> Description of problem:
> Since the update of httpd from 2.2 to 2.4 there is a new configuration
> directory (/etc/httpd/conf.modules.d) that is helpful to have which isn't
> included in the sosreport. This is nothing major, just a bit annoying to ask
> for a sosreport that gets almost everything you need, plus conf.modules.d.
> 
> I already submitted a PR and tested it to ensure it doesn't break anything
> on RHEL 6 and 7. The PR is here: 
> https://github.com/sosreport/sos/pull/466
> 
> And here is the diff (super complex :)):
> 
> diff --git a/sos/plugins/apache.py b/sos/plugins/apache.py
> index dc700cb..d21fc09 100644
> --- a/sos/plugins/apache.py
> +++ b/sos/plugins/apache.py
> @@ -35,6 +35,7 @@ class RedHatApache(Apache, RedHatPlugin):
>          self.add_copy_spec([
>              "/etc/httpd/conf/httpd.conf",
>              "/etc/httpd/conf.d/*.conf"
> +            "/etc/httpd/conf.modules.d/*.conf"
>          ])
>  
>          self.add_forbidden_path("/etc/httpd/conf/password.conf")
> 
> Currently awaiting acceptance upstream.

Thanks for the plugin update. As stated on https://github.com/csutherl/sos/commit/68ea75f35091266165a3b7e7c5333186545ec6fc, you need to add one comma to the patch.

Comment 4 Coty Sutherland 2015-02-06 16:28:35 UTC

Sorry about that, fixed it.

Comment 6 Pavel Moravec 2015-05-31 07:51:06 UTC

posted to upstream as https://github.com/sosreport/sos/commit/b43460ecaeb7e332a993fb6ea19f4808d759711f

Comment 10 errata-xmlrpc 2015-11-19 12:14:42 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2118.html