Bug 1183266

Summary: Sosreport doesn't collect conf.modules.d for httpd 2.4
Product: Red Hat Enterprise Linux 7 Reporter: Coty Sutherland <csutherl>
Component: sosAssignee: Bryn M. Reeves <bmr>
Status: CLOSED DUPLICATE QA Contact: BaseOS QE - Apps <qe-baseos-apps>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 7.0CC: agk, sbradley
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-01-19 20:44:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Coty Sutherland 2015-01-17 22:16:15 UTC
Description of problem:
Since the update of httpd from 2.2 to 2.4 there is a new configuration directory (/etc/httpd/conf.modules.d) that is helpful to have which isn't included in the sosreport. This is nothing major, just a bit annoying to ask for a sosreport that gets almost everything you need, plus conf.modules.d.

I already submitted a PR and tested it to ensure it doesn't break anything on RHEL 6 and 7. The PR is here: 
https://github.com/sosreport/sos/pull/466

And here is the diff (super complex :)):

diff --git a/sos/plugins/apache.py b/sos/plugins/apache.py
index dc700cb..d21fc09 100644
--- a/sos/plugins/apache.py
+++ b/sos/plugins/apache.py
@@ -35,6 +35,7 @@ class RedHatApache(Apache, RedHatPlugin):
         self.add_copy_spec([
             "/etc/httpd/conf/httpd.conf",
             "/etc/httpd/conf.d/*.conf"
+            "/etc/httpd/conf.modules.d/*.conf"
         ])
 
         self.add_forbidden_path("/etc/httpd/conf/password.conf")

Currently awaiting acceptance upstream.