Bug 1183273

Summary:	Review Request: gitshelf - Utility to manage git repositories
Product:	[Fedora] Fedora	Reporter:	Eduardo Mayorga <e>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	hguemar, package-review
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-01-18 17:51:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Eduardo Mayorga 2015-01-18 00:49:22 UTC

Spec URL: <https://espasmo.fedorapeople.org/gitshelf.spec>
SRPM URL: <https://espasmo.fedorapeople.org/python-gitshelf-0.0.4-1.fc20.src.rpm>
Description: <is a python library>
Fedora Account System Username:espasmo

Comment 1 hguemar 2015-01-18 13:55:51 UTC

1. submitted by Eduardo Mayorga (FAS: mayorga) confirmed by its mail, but comment #1 says FAS: espasmo (Fernando Espinoza who is not in packager group). *Please clarify this asap*
If you're not sponsored, set the FE-NEEDSPONSOR
2. spec should have the same name as the source package
3. Description is insufficient
4. please version your BR: python2-devel
5. %{_bindir gitshelf}/ WTF ?
6. %description text is not useful, besides, the first line will be processed as a comment by RPM
7. protip: if you want your review to be processed, take the time to fill in the template, especially the *title*. Put yourself in a reviewer's shoes, do you believe he'll even have a peek to a review request title "Review Request: <main package name here> - <short summary here>" ?
I fixed it in your stead but keep it in mind for the next time.
Besides, the angle brackets are not to be kept.

Comment 2 Eduardo Mayorga 2015-01-18 17:51:08 UTC

I'm closing this bug as the actual submitter is espasmo. He was logged in as me by accident.