Bug 1183286

Summary: Review Request: perl-Crypt-PWSafe3 - Read and write Passwordsafe v3 files
Product: [Fedora] Fedora Reporter: David Dick <ddick>
Component: Package ReviewAssignee: Petr Šabata <psabata>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, psabata
Target Milestone: ---Flags: psabata: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-Crypt-PWSafe3-1.16-1.fc20 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-05 12:32:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1168571, 1183258    
Bug Blocks:    

Description David Dick 2015-01-18 05:11:26 UTC 
Spec URL: https://ddick.fedorapeople.org/packages/perl-Crypt-PWSafe3.spec
SRPM URL: https://ddick.fedorapeople.org/packages/perl-Crypt-PWSafe3-1.15-1.fc20.src.rpm
Description: Read and write Passwordsafe v3 files
Fedora Account System Username: ddick
Comment 1 Petr Šabata 2015-02-11 13:57:13 UTC 
I don't like the dubious copyright statements in the source files here.  Without reading the much clearer README file, these could give the impression the code is licensed under Artistic (1.0) only.  That would be bad.  Perhaps point it out to upstream?

Also, lib/Crypt/PWSafe3/Databaseformat.pm is licensed under Artistic 2.0.  Update your License tag to reflect that.

Missing BR: Test::More, t/run.t:13

You could also add version constraints for Crypt::Random and Data::UUID.
Comment 2 David Dick 2015-02-12 19:48:47 UTC 
Upstream has re-licensed entire package under Artistic 2.0.

All other fixes applied.

Spec URL: https://ddick.fedorapeople.org/packages/perl-Crypt-PWSafe3.spec
SRPM URL: https://ddick.fedorapeople.org/packages/perl-Crypt-PWSafe3-1.16-1.fc21.src.rpm
Comment 3 Petr Šabata 2015-02-13 09:20:30 UTC 
That was fast.

Looks good.  Approving.
Comment 4 David Dick 2015-02-17 18:57:00 UTC 
Yup :) Thanks Petr.

New Package SCM Request
=======================
Package Name: perl-Crypt-PWSafe3
Short Description: Read and write Passwordsafe v3 files
Upstream URL: http://search.cpan.org/dist/Crypt-PWSafe3/
Owners: ddick
Branches: f20, f21, el6, epel7
InitialCC: perl-sig
Comment 5 Gwyn Ciesla 2015-02-17 20:29:34 UTC 
Git done (by process-git-requests).

Added f22 as we've branched.
Comment 6 Fedora Update System 2015-02-23 19:59:06 UTC 
perl-Crypt-PWSafe3-1.16-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/perl-Crypt-PWSafe3-1.16-1.fc21
Comment 7 Fedora Update System 2015-02-23 20:01:14 UTC 
perl-Crypt-PWSafe3-1.16-1.fc20 has been submitted as an update for Fedora 20.
https://admin.fedoraproject.org/updates/perl-Crypt-PWSafe3-1.16-1.fc20
Comment 8 Fedora Update System 2015-02-25 13:27:01 UTC 
perl-Crypt-PWSafe3-1.16-1.fc20 has been pushed to the Fedora 20 testing repository.
Comment 9 Fedora Update System 2015-03-05 12:32:25 UTC 
perl-Crypt-PWSafe3-1.16-1.fc21 has been pushed to the Fedora 21 stable repository.
Comment 10 Fedora Update System 2015-03-05 12:35:56 UTC 
perl-Crypt-PWSafe3-1.16-1.fc20 has been pushed to the Fedora 20 stable repository.