Bug 1184246

Summary: default thin_check options don't have --clear-needs-check-flag
Product: Red Hat Enterprise Linux 7 Reporter: Vivek Goyal <vgoyal>
Component: lvm2Assignee: Peter Rajnoha <prajnoha>
lvm2 sub component: Thin Provisioning QA Contact: Cluster QE <mspqa-list>
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: high CC: agk, cmarthal, heinzm, jbrassow, msnitzer, nperic, ovasik, prajnoha, prockai, thornber, zkabelac
Version: 7.1Keywords: Triaged
Target Milestone: rc   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: lvm2-2.02.115-1.el7 Doc Type: Bug Fix
Doc Text:
No documentation needed. This is intra-release bug.
Story Points: ---
Clone Of:
: 1184353 (view as bug list) Environment:
Last Closed: 2015-03-05 13:11:02 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1184353    

Description Vivek Goyal 2015-01-20 20:42:23 UTC
Description of problem:

I installed latest lvm2 (lvm2-2.02.114-5.el7.x86_64) on rhel7.1 virtual machine.
and then I did "lvm dumpconfig --type default | grep thin_check_options". And following is output.

 thin_check_options="-q"

I was expecting default to be.


thin_check_options="-q --clear-needs-check-flag"

I am expecting above to be default so that needs-check flag clears on the
pool automatically during thin pool volume activation.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Zdenek Kabelac 2015-01-20 20:47:42 UTC
Configure log from builds needs to be checked for WARNINGs:

These comes from the latest build and are quite serious:

checking whether to include thin provisioning... internal
configure: WARNING: /usr/sbin/thin_check: Bad version "" found
checking for x86_64-redhat-linux-gnu-thin_restore... no
checking for thin_restore... no
checking whether thin_check supports the needs-check flag... configure: WARNING: thin_restore not found in path /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/builddir/.local/bin:/builddir/bin
no
checking whether to include cache... internal
checking for x86_64-redhat-linux-gnu-cache_check... no
checking for cache_check... no
configure: WARNING: cache_check not found in path /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/builddir/.local/bin:/builddir/bin
checking for x86_64-redhat-linux-gnu-cache_dump... no
checking for cache_dump... no
configure: WARNING: cache_dump not found in path /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/builddir/.local/bin:/builddir/bin
checking for x86_64-redhat-linux-gnu-cache_repair... no
checking for cache_repair... no
configure: WARNING: cache_repair not found in path /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/builddir/.local/bin:/builddir/bin
checking for x86_64-redhat-linux-gnu-cache_restore... no
checking for cache_restore... no
configure: WARNING: cache_restore not found in path /usr/bin:/bin:/usr/sbin:/sbin:/usr/local/sbin:/builddir/.local/bin:/builddir/bin

...

configure: WARNING: unrecognized options: --disable-dependency-tracking
configure: WARNING: Support for thin provisioning is limited since some thin provisioning tools are missing!
configure: WARNING: You should also install thin_check vsn 0.3.2 (or later) to use lvm2 thin provisioning
configure: WARNING: Support for cache is limited since some cache tools are missing!

Comment 3 Alasdair Kergon 2015-01-20 22:51:20 UTC
Missing BuildRequires, so it's not detecting the tools and missing these settings out of the build.

Comment 4 Peter Rajnoha 2015-01-21 14:07:00 UTC
(In reply to Alasdair Kergon from comment #3)
> Missing BuildRequires, so it's not detecting the tools and missing these
> settings out of the build.

Added to the lvm2 spec file.

Comment 6 Corey Marthaler 2015-01-22 21:31:19 UTC
Marking verified in the latest rpms.

lvm2-2.02.114-5.el7:
[root@host-113 ~]# lvm dumpconfig --type default | grep thin_check_options
        thin_check_options="-q"


lvm2-2.02.115-2.el7:
[root@host-114 ~]# lvm dumpconfig --type default | grep thin_check_options
        thin_check_options="-q --clear-needs-check-flag"

Comment 8 errata-xmlrpc 2015-03-05 13:11:02 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0513.html