Bug 1184370

Summary: [New] - Removing brick with out migrating data from the bricks fails.
Product: [Retired] oVirt Reporter: RamaKasturi <knarra>
Component: ovirt-engine-webadminAssignee: anmol babu <anbabu>
Status: CLOSED CURRENTRELEASE QA Contact: Arthy Loganathan <aloganat>
Severity: high Docs Contact:
Priority: medium    
Version: 3.5CC: bugs, ecohen, gklein, knarra, lsurette, mgoldboi, rbalakri, rhsc-qe-bugs, sabose, yeylon
Target Milestone: ---   
Target Release: 3.6.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: gluster
Fixed In Version: ovirt-engine-3.6.0-0.0.master.20150515172356.git426b5a1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-04 11:17:49 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1187461    

Description RamaKasturi 2015-01-21 08:57:12 UTC
Description of problem:
When user tries to remove a brick with out migrating data on them, brick does not get removed from the volume and it gets added as a  new brick to the volume and data migration on that brick starts.

Version-Release number of selected component (if applicable):
ovirt-engine-webadmin-portal-3.6.0-0.0.master.20150105124153.git669ddc1.el6.noarch

How reproducible:
Always

Steps to Reproduce:
1. Create a volume of type distribute.
2. Click on the bricks sub tab.
3. select one brick from the volume and click remove.
4. In the remove brick dialog box uncheck "Migrate data from bricks".

Actual results:
Brick gets removed from the volume and gets added as a new brick.
Data migration starts on that brick.

Expected results:
Brick should be removed from the volume.
Data migration should not be started on that brick as migrate data from bricks option is unchecked.

Additional info:

Comment 1 Sahina Bose 2015-03-30 07:12:30 UTC
Please attach logs

Comment 2 RamaKasturi 2015-04-06 09:23:31 UTC
please find the logs in the link provided below. Attaching engine and vdsm logs.

http://rhsqe-repo.lab.eng.blr.redhat.com/sosreports/rhsc/1184370/

Comment 3 Darshan 2015-04-08 10:44:17 UTC
This issue is seen only in json-rpc mode. Mostly engine is not invoking the proper vdsm verb in json rpc mode. It has to invoke GlusterVolume.removeBrickForce() when brick is to be removed without data migration.

Comment 4 anmol babu 2015-04-08 19:40:17 UTC
You are right Darshan this is because when JsonRpcVdsServer was added it missed the conditional handling of a force and non-force remove bricks.
However, I find that in xml-rpc mode, the remove brick is handled conditionally appropriately.

Comment 5 Arthy Loganathan 2015-05-19 12:24:43 UTC
Verified the fix on build
ovirt-engine-3.6.0-0.0.master.20150518173633.gitcf0f078.el6.noarch

It works fine in json-rpc mode.

Comment 6 Sandro Bonazzola 2015-11-04 11:17:49 UTC
oVirt 3.6.0 has been released on November 4th, 2015 and should fix this issue.
If problems still persist, please open a new BZ and reference this one.