Bug 1184575

Summary: RH Updates: Satellite 5 URL must be in "scheme://sat5.host.acme/XMLRPC" format
Product: Red Hat CloudForms Management Engine Reporter: Jan Krocil <jkrocil>
Component: UI - OPSAssignee: Brandon Dunne <bdunne>
Status: CLOSED ERRATA QA Contact: Dave Johnson <dajohnso>
Severity: high Docs Contact:
Priority: unspecified    
Version: 5.3.0CC: gmccullo, jhardy, jocarter, mfeifer, obarenbo, snansi, xlecauch
Target Milestone: GA   
Target Release: 5.4.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.4.0.0.11 Doc Type: Bug Fix
Doc Text:
In the previous version of CloudForms Management Engine, typing an incorrect URL for a Red Hat Satellite service would result in an inability to update the CloudForms Management Engine appliance. This was because there was no validation of the URL entered for the Satellite service. This issue was fixed by validating the Satellite service URL against a regular expression. The user is now presented with an error message if this URL is in the wrong format.
 Story Points: ---
Clone Of:
: 1185462 (view as bug list) Environment:
Last Closed: 2015-06-16 12:48:16 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1185462    

Description Jan Krocil 2015-01-21 17:06:04 UTC 
Description of problem:
The Sat5 URL is guaranteed to use "/XMLRPC" as the path part; currently, it has to be entered. Customers either have to be informed about that (on-hover info bubble directly in CFME or through docs) or CFME has to append it automatically.

The scheme part (http/https), when omited, creates an issue as well => it could ideally default to https, when not entered (presuming our customers care about security). It's quite possible that the scheme defaults to http right now (as I haven't gone through the internals), but I wasn't able to register to our Sat5 without it (since it requires https).

If these two thing are amended, entering only the host part of the URL would suffice.

"https://my.sat5.acme/XMLRPC" would turn into "my.sat5.acme" (which is what one of our customers tried to do today, facing an issue).

Preferably, this would be fixed in CFME code as described above, not in docs, because registration to Sat 5 should be as straightforward and painless for the customer as possible.

Version-Release number of selected component (if applicable):
5.2.3.6

How reproducible:
-

Steps to Reproduce:
-

Actual results:
-

Expected results:
-

Additional info:
-
Comment 2 CFME Bot 2015-01-23 18:36:18 UTC 
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/844a95b41883a3d40e786469e2f32fc85c7cacee

commit 844a95b41883a3d40e786469e2f32fc85c7cacee
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Jan 22 17:04:18 2015 -0500
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Jan 23 11:45:09 2015 -0500

    Validate Satellite 5 registration_server address
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1184575

 vmdb/app/models/miq_database.rb | 8 ++++++++
 1 file changed, 8 insertions(+)
Comment 3 CFME Bot 2015-01-23 18:36:23 UTC 
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/998eeab6221d1c01c3eb6c3491b132e6cb5ae78e

commit 998eeab6221d1c01c3eb6c3491b132e6cb5ae78e
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jan 23 10:40:02 2015 -0500
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Jan 23 11:45:09 2015 -0500

    Changed UI to show RHN Satellite Server validation messages.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1184575

 .../app/controllers/ops_controller/settings/common.rb |  6 ------
 vmdb/app/controllers/ops_controller/settings/rhn.rb   | 19 +++++++++++++++++--
 2 files changed, 17 insertions(+), 8 deletions(-)
Comment 4 CFME Bot 2015-01-23 18:36:27 UTC 
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/f932f108a52a672116eb95802f7ee5f451b93c8c

commit f932f108a52a672116eb95802f7ee5f451b93c8c
Author:     Brandon Dunne <bdunne>
AuthorDate: Fri Jan 23 13:12:40 2015 -0500
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Jan 23 13:12:40 2015 -0500

    Prefer https in error message
    
    [skip ci]
    https://bugzilla.redhat.com/show_bug.cgi?id=1184575

 vmdb/app/models/miq_database.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 CFME Bot 2015-01-23 20:05:57 UTC 
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=0dd39c136640339b0bad62a7e05b0afa7f392c5f

commit 0dd39c136640339b0bad62a7e05b0afa7f392c5f
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Jan 22 17:04:18 2015 -0500
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Jan 23 14:27:41 2015 -0500

    Validate Satellite 5 registration_server address
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1184575

 vmdb/app/models/miq_database.rb | 8 ++++++++
 1 file changed, 8 insertions(+)
Comment 6 CFME Bot 2015-01-23 20:06:01 UTC 
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=8e1fda9598e1cce7c56bfc90e6ecaa23de9db00d

commit 8e1fda9598e1cce7c56bfc90e6ecaa23de9db00d
Author:     Harpreet Kataria <hkataria>
AuthorDate: Fri Jan 23 10:40:02 2015 -0500
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Jan 23 14:54:54 2015 -0500

    Changed UI to show RHN Satellite Server validation messages.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1184575

 .../app/controllers/ops_controller/settings/common.rb |  6 ------
 vmdb/app/controllers/ops_controller/settings/rhn.rb   | 19 +++++++++++++++++--
 vmdb/config/locales/en.yml                            |  1 +
 3 files changed, 18 insertions(+), 8 deletions(-)
Comment 7 CFME Bot 2015-01-23 20:06:05 UTC 
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=0e32d8d5a8a6bfd36d25423b50605a8686178cbb

commit 0e32d8d5a8a6bfd36d25423b50605a8686178cbb
Author:     Brandon Dunne <bdunne>
AuthorDate: Fri Jan 23 11:31:34 2015 -0500
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Jan 23 14:57:09 2015 -0500

    Rubocop cleanup
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1184575

 vmdb/app/controllers/ops_controller/settings/rhn.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 8 CFME Bot 2015-01-23 20:06:09 UTC 
New commit detected on cfme/5.3.z:
https://code.engineering.redhat.com/gerrit/gitweb?p=cfme.git;a=commitdiff;h=dffd114f0e179d58d2b41712303a1a604b626275

commit dffd114f0e179d58d2b41712303a1a604b626275
Author:     Brandon Dunne <bdunne>
AuthorDate: Fri Jan 23 13:12:40 2015 -0500
Commit:     Brandon Dunne <bdunne>
CommitDate: Fri Jan 23 14:59:57 2015 -0500

    Prefer https in error message
    
    [skip ci]
    https://bugzilla.redhat.com/show_bug.cgi?id=1184575

 vmdb/app/models/miq_database.rb |  2 +-
 vmdb/config/locales/en.yml      | 16 ++++++++--------
 2 files changed, 9 insertions(+), 9 deletions(-)
Comment 10 Jan Krocil 2015-03-11 17:08:23 UTC 
Verified fixed in 5.4.0.0.11 - 5.4.0.0.11.20150309201930_8b6a235.

Error flash message with "Validation failed: Registration server expected https://server.example.com/XMLRPC" appears when the URL is not in the correct format.
Comment 12 errata-xmlrpc 2015-06-16 12:48:16 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1100.html