Bug 1185076

Summary:	Review Request: golang-github-golang-protobuf - Go support for Google's protocol buffers
Product:	[Fedora] Fedora	Reporter:	Jan Chaloupka <jchaloup>
Component:	Package Review	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED NOTABUG	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review
Target Milestone:	---	Keywords:	Reopened
Target Release:	---	Flags:	jchaloup: fedora-review?
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-01-26 14:50:17 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1185082, 1185281

Description Jan Chaloupka 2015-01-22 20:43:04 UTC

Spec URL: https://jchaloup.fedorapeople.org/reviews/golang-github-golang-protobuf/golang-github-golang-protobuf.spec

SRPM URL: https://jchaloup.fedorapeople.org/reviews/golang-github-golang-protobuf/golang-github-golang-protobuf-0-0.1.git7f07925.fc20.src.rpm

Description: Go support for Google's protocol buffers

Fedora Account System Username: jchaloup

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=8703345

$ rpmlint golang-github-golang-protobuf-0-0.1.git7f07925.fc20.src.rpm golang-github-golang-protobuf-devel-0-0.1.git7f07925.fc20.noarch.rpm golang-github-golang-protobuf.spec
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

Upstream: https://github.com/golang/protobuf

Comment 1 Lokesh Mandvekar 2015-01-25 01:34:47 UTC

this is the same as golang-googlecode-goprotobuf, looks like they moved development over to github, let's update the existing package with metaproviding this package.

Please reopen this if you feel we should use this package and retire the old one.

Either way, as far as this spec file goes, it should also generate protoc-gen-go (http://pkgs.fedoraproject.org/cgit/golang-googlecode-goprotobuf.git/tree/golang-googlecode-goprotobuf.spec) and maybe we don't need to export testdata (unless required by something else)

Comment 2 Lokesh Mandvekar 2015-01-25 01:50:18 UTC

added you to golang-googlecode-goprotobuf, feel free to update it or we could continue this one instead if it makes things easier going forward.

Comment 3 Jan Chaloupka 2015-01-26 13:30:50 UTC

Thanks Lokesh. Lets continue with this one. This is not the only one repo being moved to a different one with changing its import path.

Comment 4 Lokesh Mandvekar 2015-01-26 14:45:15 UTC

Alright, please update the spec file to include protoc-gen-go. Also, since it looks like this path will be the standard path moving forward, do you want this package to metaprovide/obsolete the other package, or keep them separate?

Comment 5 Jan Chaloupka 2015-01-26 14:50:17 UTC

Sorry, I meant this one as the old one :) My mind is a little bit twisted :P. Already updated to old one package.