Bug 1185096

Summary: debug-promote implementation
Product: Red Hat Enterprise Linux 7 Reporter: Gabriele Cerami <gcerami>
Component: pcsAssignee: Tomas Jelinek <tojeline>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2CC: abeekhof, cluster-maint, rsteiger, tojeline
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcs-0.9.141-1.el7 Doc Type: Enhancement
Doc Text:
Feature: Add support for resource agents debugging commands provided by pacemaker. Reason: Make it easier to debug resource agents. Result: User is able to debug resource agents using pcs.
Story Points: ---
Clone Of:
: 1205188 (view as bug list) Environment:
Last Closed: 2015-11-19 09:34:21 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1205188    
Bug Blocks:    
Attachments:
Description Flags
proposed fix none

Description Gabriele Cerami 2015-01-22 21:46:39 UTC
Description of problem:

For resource agents like the one that manages galera, promote is the real start.
If something goes wrong during promote, it's hard to find logs and messages that explain what is going wrong.
It should be good to have something similar to debug-start but for promote operation.


Version-Release number of selected component (if applicable):
Version     : 0.9.115
Release     : 32.el7

Comment 3 Andrew Beekhof 2015-03-23 22:11:19 UTC
Probably best to clone it instead - so that we don't forget to update pcs once its implemented in pacemaker

Comment 5 Tomas Jelinek 2015-06-17 15:33:06 UTC
Created attachment 1039999 [details]
proposed fix

Test:

[root@rh71-node1:~]# pcs resource create dummy dummy
[root@rh71-node1:~]# pcs resource create state stateful --master
Warning: changing a monitor operation interval from 10 to 11 to make the operation unique
[root@rh71-node1:~]# pcs resource debug-promote state
Operation promote for state:0 (ocf:pacemaker:Stateful) returned 0
[root@rh71-node1:~]# echo $?
0
[root@rh71-node1:~]# pcs resource debug-demote state
Operation demote for state:0 (ocf:pacemaker:Stateful) returned 0
[root@rh71-node1:~]# echo $?
0
[root@rh71-node1:~]# pcs resource debug-promote dummy
Error performing operation: No such process
Operation promote for dummy (ocf:heartbeat:Dummy) returned 3
 >  stdout: usage: /usr/lib/ocf/resource.d/heartbeat/Dummy {start|stop|monitor|migrate_to|migrate_from|validate-all|meta-data}
 >  stdout: 
 >  stdout: Expects to have a fully populated OCF RA-compliant environment set.
[root@rh71-node1:~]# echo $?
3
[root@rh71-node1:~]# pcs resource debug-demote dummy
Error performing operation: No such process
Operation demote for dummy (ocf:heartbeat:Dummy) returned 3
 >  stdout: usage: /usr/lib/ocf/resource.d/heartbeat/Dummy {start|stop|monitor|migrate_to|migrate_from|validate-all|meta-data}
 >  stdout: 
 >  stdout: Expects to have a fully populated OCF RA-compliant environment set.
[root@rh71-node1:~]# echo $?
3

Comment 6 Tomas Jelinek 2015-06-23 12:50:47 UTC
Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.140-1.el7.x86_64
[root@rh71-node1:~]# pcs resource create dummy dummy
[root@rh71-node1:~]# pcs resource create state stateful --master
Warning: changing a monitor operation interval from 10 to 11 to make the operation unique
[root@rh71-node1:~]# pcs resource debug-promote state

Usage: pcs resource [commands]...
{snip}
[root@rh71-node1:~]# pcs resource debug-demote state

Usage: pcs resource [commands]...
{snip}



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.141-1.el7.x86_64
See the previous comment bz1185096#c5

Comment 10 errata-xmlrpc 2015-11-19 09:34:21 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html