Bug 1185558
| Summary: | oggenc crashes when encoding pcm from stdin | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Thomas Köller <thomas> | |
| Component: | vorbis-tools | Assignee: | Kamil Dudka <kdudka> | |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 21 | CC: | bugreporter1, hdegoede, kdudka | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | x86_64 | |||
| OS: | Linux | |||
| Whiteboard: | ||||
| Fixed In Version: | vorbis-tools-1.4.0-13.fc20 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1569426 (view as bug list) | Environment: | ||
| Last Closed: | 2015-01-30 04:35:32 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1185272, 1569426 | |||
*** Bug 836320 has been marked as a duplicate of this bug. *** Thank you for reporting the bug! The following patch will fix it:
From: Kamil Dudka <kdudka>
Date: Mon, 26 Jan 2015 12:33:19 +0100
Subject: [PATCH] oggenc: do not use stack variable out of its scope of validity
---
oggenc/oggenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/oggenc/oggenc.c b/oggenc/oggenc.c
index ea105b2..759a3ee 100644
--- a/oggenc/oggenc.c
+++ b/oggenc/oggenc.c
@@ -239,7 +239,7 @@ int main(int argc, char **argv)
if(opt.rawmode)
{
- input_format raw_format = {NULL, 0, raw_open, wav_close, "raw",
+ static input_format raw_format = {NULL, 0, raw_open, wav_close, "raw",
N_("RAW file reader")};
enc_opts.rate=opt.raw_samplerate;
patch sent upstream: http://lists.xiph.org/pipermail/vorbis-dev/2015-January/020422.html fixed in vorbis-tools-1.4.0-18.fc22 vorbis-tools-1.4.0-18.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/vorbis-tools-1.4.0-18.fc21 vorbis-tools-1.4.0-13.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/vorbis-tools-1.4.0-13.fc20 Package vorbis-tools-1.4.0-13.fc20: * should fix your issue, * was pushed to the Fedora 20 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing vorbis-tools-1.4.0-13.fc20' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-1191/vorbis-tools-1.4.0-13.fc20 then log in and leave karma (feedback). vorbis-tools-1.4.0-18.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. vorbis-tools-1.4.0-13.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: When encoding raw pcm data from a pipe, oggenc crashes when it reaches the end of the input data. Version-Release number of selected component (if applicable): vorbis-tools-1.4.0-17.fc21.x86_64 How reproducible: always Steps to Reproduce: dd if=/dev/zero bs=1024 count=100000 status=none | oggenc -r -o test.ogg - Actual results: [thomas@sarkovy ~]$ dd if=/dev/zero bs=1024 count=100000 status=none | oggenc -r -o test.ogg - Encoding standard input to "test.ogg" at quality 3.00 Encoding [ 0m06s so far] \ Done encoding file "test.ogg" File length: 9m 40.0s Elapsed time: 0m 06.6s Rate: 88.4670 Average bitrate: 0.7 kb/s Segmentation fault (core dumped) Expected results: Should not segfault obviously Additional info: The above test command is only meant to demonstrate the problem. In reality, the data to encode is produced by cdparanoia reading a CD track.