Bug 1185796

Summary: fix switching between secure and insecure forward zones
Product: [Fedora] Fedora Reporter: Pavel Šimerda (pavlix) <psimerda>
Component: dnssec-triggerAssignee: Pavel Šimerda (pavlix) <psimerda>
Status: CLOSED ERRATA QA Contact: Pavel Šimerda (pavlix) <psimerda>
Severity: high Docs Contact:
Priority: unspecified    
Version: 21CC: pj.pandit, psimerda, pspacek, pwouters, thozza
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: dnssec-trigger-0.12-20.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-26 22:04:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
patch
none
patch to fix the two issues none

Description Pavel Šimerda (pavlix) 2015-01-26 10:16:41 UTC
Created attachment 984150 [details]
patch

As dnssec-trigger-script cannot rely on a specific on a current version of Unbound, the upstream code attempts to check whether the list of servers for a zone should be changed and skips the action if not. The attached patch makes sure we always rewrite the forward zone as it may be switching between secure and insecure.

Comment 1 Pavel Šimerda (pavlix) 2015-01-26 10:53:27 UTC
Created attachment 984155 [details]
patch to fix the two issues

Furthermore I realized that there is a problem with switching from insecure mode to secure mode using a single *forward_add* command. While there is a "+i" switch that makes sure the zone is insecure, there's no "-i" switch to make sure the zone is secure (when insecure previously). Therefore it is necessary to fix up the secure state using *insecure_remove* afterwards.

Upstream can change this in the future based on unbound-control improvements.

Comment 2 Tomáš Hozza 2015-01-26 11:23:41 UTC
(In reply to Pavel Šimerda (pavlix) from comment #1)
> Furthermore I realized that there is a problem with switching from insecure
> mode to secure mode using a single *forward_add* command. While there is a
> "+i" switch that makes sure the zone is insecure, there's no "-i" switch to
> make sure the zone is secure (when insecure previously). Therefore it is
> necessary to fix up the secure state using *insecure_remove* afterwards.

Yes, basically you can use the 'insecure_remove' OR you could remove the insecure forward zone completely and re-add it as secure. However the final effect should be the same, so I think it is OK to do it the way you've proposed.

Comment 3 Pavel Šimerda (pavlix) 2015-01-26 11:39:38 UTC
Thanks.

Comment 4 Fedora Update System 2015-01-26 20:47:43 UTC
dnssec-trigger-0.12-18.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/dnssec-trigger-0.12-18.fc21

Comment 5 Fedora Update System 2015-01-28 19:56:22 UTC
Package dnssec-trigger-0.12-18.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing dnssec-trigger-0.12-18.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-1279/dnssec-trigger-0.12-18.fc21
then log in and leave karma (feedback).

Comment 6 Fedora Update System 2015-03-17 11:06:45 UTC
dnssec-trigger-0.12-19.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/FEDORA-2015-3864/dnssec-trigger-0.12-19.fc22

Comment 7 Fedora Update System 2015-03-17 11:07:02 UTC
dnssec-trigger-0.12-19.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/FEDORA-2015-3843/dnssec-trigger-0.12-19.fc21

Comment 8 Fedora Update System 2015-03-26 22:04:39 UTC
dnssec-trigger-0.12-19.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2015-04-21 18:48:49 UTC
dnssec-trigger-0.12-20.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.