Bug 1185840

Summary: Ad-hoc subprocess without completion condition is not highlighted after validation
Product: [Retired] JBoss BPMS Platform 6 Reporter: Tomas Livora <tlivora>
Component: jBPM CoreAssignee: Tihomir Surdilovic <tsurdilo>
Status: CLOSED EOL QA Contact: Kirill Gaevskii <kgaevski>
Severity: medium Docs Contact: Dawn Eisner <deisner>
Priority: medium    
Version: 6.1.0CC: kverlaen, mczernek, rrajasek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
When creating a simple process with an Ad-hoc subprocess (i.e. Start -> Ad-hoc subprocess -> End) and validating the process in the Designer, a wrong node is highlighted as invalid. This is caused by a related bug fix. There are no workarounds for this issue at this stage.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-27 19:48:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
adhoc process validation
none
adhoc subprocess validation none

Description Tomas Livora 2015-01-26 11:59:02 UTC 
Description of problem:
Since bug 1170281 was fixed, the validator checks if the completion condition of an ad-hoc subprocess is not empty. After the validation is performed in the Designer, wrong node is highlighted as invalid.

Version-Release number of selected component (if applicable):
6.1.0 ER4

Steps to Reproduce:
1. Create a process with Start -> Ad-hoc subprocess -> End.
2. Run the validation.
3. See which node is highlighted.

Actual results:
Start node

Expected results:
Ad-hoc subprocess node
Comment 1 Kirill Gaevskii 2015-12-08 12:50:14 UTC 
Still valid.
P.S. other problems like "Node has no outgoing connections" or "Node has no incoming connections" is highlight.
Comment 2 Tihomir Surdilovic 2015-12-22 16:34:34 UTC 
This issue is jBPM RuleProcessValidator (it is still checking if completion condition is empty and shows error if so) and not in Designer. 

The Ad-hoc subprocess for me shows up correctly (see attached video). i will update the RuleProcessValidator for the fix
Comment 3 Tihomir Surdilovic 2015-12-22 16:34:59 UTC 
Created attachment 1108673 [details]
adhoc process validation
Comment 5 Tihomir Surdilovic 2015-12-22 16:48:25 UTC 
Looking at this further BZ 1170281 also updates the validator: 
https://github.com/droolsjbpm/jbpm/commit/f37cf2f6f16f00af6ae308bc5274352ed1a3fc51#diff-3f817daf9ffde3edd8cfc8fc3e9dd0b3R411

and given that Designer correctly highlights the ad-hoc subprocess (see attached video) I don't really see an issue here.
Comment 6 Tomas Livora 2016-01-05 14:40:41 UTC 
Created attachment 1111843 [details]
adhoc subprocess validation

The bug is still present in BPM Suite 6.2.0 GA