Bug 1187004
| Summary: | Lenovo Ideapad Z570 backlight brightness keys adjust OSD but not screen brightness | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Be <be.0> |
| Component: | kernel | Assignee: | Josh Boyer <jwboyer> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 21 | CC: | gansalmon, hdegoede, itamar, jonathan, jwboyer, kernel-maint, madhu.chinakonda, mchehab |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | kernel-3.19.3-100.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-29 04:31:15 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Attachments: | |||
|
Description
Be
2015-01-29 06:26:58 UTC
Created attachment 988090 [details]
Proposed patch fixing this
Hi, Thanks for the bug report. I've started a kernel scratch-build with a patch added which should fix this. Please download the following rpms: kernel-3.17.8-...rpm kernel-core-3.17.8-...rpm kernel-modules-3.17.8-...rpm For your arch from here: http://koji.fedoraproject.org/koji/taskinfo?taskID=8818095 (note this is still building atm) Save them all to the same directory (which should not contain other rpms) and do: sudo rpm -ivh kernel-*.rpm From within that directory. And then boot into the new kernel and check if the backlight works as expected. Regards, Hans Nope, that did not fix the issue. :/ Now the OSD will immediately jump back to 100% when I try to decrease the brightness, like when using the kernel argument acpi_backlight=vendor before. Echoing to /sys/class/backlight/intel_backlight/brightness still works. There is now an 'ideapad' directory instead of 'acpi_video0' in /sys/class/backlight. Echoing to /sys/class/backlight/acpi_video0/brightness prints the same error (bash: echo: write error: Invalid argument). # ls -l /sys/class/backlight/ total 0 lrwxrwxrwx. 1 root root 0 Feb 4 18:47 ideapad -> ../../devices/pci0000:00/0000:00:1f.0/PNP0C09:00/VPC2004:00/backlight/ideapad lrwxrwxrwx. 1 root root 0 Feb 4 18:47 intel_backlight -> ../../devices/pci0000:00/0000:00:02.0/drm/card0/card0-LVDS-1/intel_backlight Ugh, so with me getting the acer-wmi driver out of the way, the ideapad sees its chance to register its own backlight deivce, great (not). Can you try creating a /etc/modprobe.d/ideapad.conf with the following in there: blacklist ideapad-laptop And then reboot? This may cause you to loose some functionality of certain Fn + Function-Key key-combinations, but it should get your backlight to work, which will show that we're on the right track, once that is confirmed I need to rethink this. That fixes it. :) I tried booting into 3.18.3-201.fc21.x86_64 with ideapad-laptop blacklisted and it works as well, so the patch you attached above is unnecessary. Function and volume keys all still work. (In reply to Be from comment #5) > That fixes it. :) I tried booting into 3.18.3-201.fc21.x86_64 with > ideapad-laptop blacklisted and it works as well, so the patch you attached > above is unnecessary. Function and volume keys all still work. acpi_video0 is no longer present with 3.18.3-201.fc21.x86_64 with ideapad-laptop blacklisted: $ ls -l /sys/class/backlight/ total 0 lrwxrwxrwx. 1 root root 0 Feb 5 10:50 intel_backlight -> ../../devices/pci0000:00/0000:00:02.0/drm/card0/card0-LVDS-1/intel_backlight So should the ideapad-laptop kernel module be modified to prevent loading for Lenovo Z570? Hi, So I've done a new set of patches which should really fix this. Please download the following rpms: kernel-3.18.8-...rpm kernel-core-3.18.8-...rpm kernel-modules-3.18.8-...rpm For your arch from here: http://koji.fedoraproject.org/koji/taskinfo?taskID=9129619 (note this is still building atm) Save them all to the same directory (which should not contain other rpms) and do: sudo rpm -ivh kernel-*.rpm From within that directory. Then mv /etc/modprobe.d/ideapad.conf to your home dir (so that it is no longer used), and then boot into the new kernel and check if the backlight works as expected. Thanks & Regards, Hans Nope, still doesn't work without ideapad module blacklisted. # uname -r 3.18.8-201.rhbz1187004.fc21.x86_64 # ls -l /sys/class/backlight/ total 0 lrwxrwxrwx. 1 root root 0 Mar 3 20:39 ideapad -> ../../devices/pci0000:00/0000:00:1f.0/PNP0C09:00/VPC2004:00/backlight/ideapad lrwxrwxrwx. 1 root root 0 Mar 3 20:38 intel_backlight -> ../../devices/pci0000:00/0000:00:02.0/drm/card0/card0-LVDS-1/intel_backlight Hi, Ah, it took me a while, but this is caused by this recent(ish) commit, which (sorta) conflicts with my patches: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a11d342f Which suggests that the ideapad backlight interface should actually work ... can you try poking the brightness file directly in sysfs and see if this works or not (with the 3.18.8 kernel I build) ? Regards, Hans # uname -r 3.18.8-201.rhbz1187004.fc21.x86_64 # echo 100 > /sys/class/backlight/ideapad/brightness bash: echo: write error: Invalid argument # echo 100 > /sys/class/backlight/intel_backlight/brightness # works Hi, (In reply to Be from comment #12) > # uname -r > 3.18.8-201.rhbz1187004.fc21.x86_64 > # echo 100 > /sys/class/backlight/ideapad/brightness > bash: echo: write error: Invalid argument Hmm, firmware interfaces typically may have a different range, try doing a "cat max_brightness" first and then writing values in the range of 0 - max_brightness. Regards, Hans max_brightness for ideapad is 10. I tried echoing values from 0 to 10 to brightness for ideapad. KDE's OSD popped up and showed the brightness was 10x whatever I echoed to brightness (that is, the OSD showed 20% when I echoed 2). However, this did not actually affect the backlight. Only echoing to intel_backlight/brightness changed the backlight (but not KDE's OSD). (In reply to Be from comment #14) > max_brightness for ideapad is 10. I tried echoing values from 0 to 10 to > brightness for ideapad. KDE's OSD popped up and showed the brightness was > 10x whatever I echoed to brightness (that is, the OSD showed 20% when I > echoed 2). However, this did not actually affect the backlight. Only echoing > to intel_backlight/brightness changed the backlight (but not KDE's OSD). Ok, thanks for testing I'll send a mail to the author of the commit which somewhat conflicts with my fix: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=a11d342f And I'll put you in the Cc, and then we'll go from there. Hi, So I've done a new set of patches which should really really fix this. Please download the following rpms: kernel-3.19.1-...rpm kernel-core-3.19.1-...rpm kernel-modules-3.19.1-...rpm For your arch from here: http://koji.fedoraproject.org/koji/taskinfo?taskID=9273358 (note this is still building atm) Save them all to the same directory (which should not contain other rpms) and do: sudo rpm -ivh kernel-*.rpm From within that directory. Then mv /etc/modprobe.d/ideapad.conf to your home dir (so that it is no longer used), and then boot into the new kernel and check if the backlight works as expected. Thanks & Regards, Hans That works, thanks. Volume keys still work too. intel_backlight is the only symlink in /sys/class/backlight Created attachment 1004363 [details]
[PATCH 1/2] acpi: video: Allow forcing native backlight on non win8 machines
Created attachment 1004364 [details]
[PATCH 2/2] acpi: video: Add force native backlight quirk for Lenovo Ideapad Z570
Hi, (In reply to Be from comment #17) > That works, thanks. Volume keys still work too. intel_backlight is the only > symlink in /sys/class/backlight Good thanks for testing this. Josh can you please add the 2 patches which I've just attached to the Fedora kernel builds to fix this until the fixes trickle down through upstream ? The first (preperation) patch is already queued up upstream, the second patch I've just send upstream this morning. Thanks & Regards, Hans Added, thanks! kernel-3.19.2-201.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/FEDORA-2015-4457/kernel-3.19.2-201.fc21 kernel-4.0.0-0.rc5.git1.3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/kernel-4.0.0-0.rc5.git1.3.fc22 Package kernel-3.19.2-201.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing kernel-3.19.2-201.fc21' as soon as you are able to, then reboot. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-4457/kernel-3.19.2-201.fc21 then log in and leave karma (feedback). Without blacklisting ideapad_laptop with kernel-3.19.2-200.fc21.x86_64, both ideapad and intel_backlight appear in /sys/class/backlight. Upon boot, the backlight state is restored to where it was, but I still cannot change the brightness with the brightness keys. KDE's OSD shows that the brightness is at 100%. When I try to turn it down, the OSD goes down to 90 then jumps back to 100. kernel-3.19.3-100.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/kernel-3.19.3-100.fc20 kernel-3.19.2-201.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. kernel-3.19.3-100.fc20 has been pushed to the Fedora 20 stable repository. If problems still persist, please make note of it in this bug report. |