Bug 1187097
| Summary: | Too much logging | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pavel Reichl <preichl> | |
| Component: | cyrus-sasl | Assignee: | Jakub Jelen <jjelen> | |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | medium | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 21 | CC: | jjelen, mkosek, plautrba, preichl, tmraz, vanmeeuwen+fedora | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | cyrus-sasl-2.1.26-23.fc22 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1273580 1274734 (view as bug list) | Environment: | ||
| Last Closed: | 2015-06-13 06:38:22 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | ||||
| Bug Blocks: | 1274734 | |||
|
Description
Pavel Reichl
2015-01-29 10:47:28 UTC
If I am right, the call > params->utils->log(NULL, SASL_LOG_DEBUG, should get some conn, as the other calls from this or other plugins, like this: > params->utils->log(params->utils->conn, SASL_LOG_DEBUG, which would give as context for logging, possibility to filter log_levels and preferably ability to use some additional callbacks. But I don't have any reproducer here to test the behaviour and results. Can you provide me some, or can you test it with this "fix"? Hello Jakub, sorry for late reply. I tried little experimenting with gdb and it seems to me, that it could work - my provided callback was used. I'm sorry but my testing environment is set of local VMs and it not easy to recreate it using VMs from publicly accessible lab. But If you provide me with updated package I can test if this bug goes away. Do you have any idea why NULL was passed instead of 'params->utils->conn'? Thanks. I made scratch build with this change (putting conn to log calls): http://koji.fedoraproject.org/koji/taskinfo?taskID=9310018 Unfortunately, I am not yet enough knowledgeable about cyrus-sasl internals so I got inspired with with some other plugins. This is in git probably from the beginning of GSSAPI plugin and probably copy&pasted from other plugins? The origin is hard to track. As you can notice, some plugins do log with params->utils->conn (anonymous, digestmd5, gs2) and some not without it (quite much all the others). You can see it with grep on upstream git: # git grep "utils->log(" If it will solve your problem and will be helpful for you, we can try to push it to upstream. Fix solves the problem in SSSD, so yes, please try to propagate it to upstream. Any idea how long it could take? I don't know. I see they reacted quite fast on mailing list when you were discussing this topic so if we agree with them on some changes, they can be in fedora next week, I hope. I don't want to do it earlier than upstream not to cause incompatibility. Mailing list is traditionally without any answer so I'm pusshing this change in Fedora 22 and Rawhide. cyrus-sasl-2.1.26-23.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/cyrus-sasl-2.1.26-23.fc22 Package cyrus-sasl-2.1.26-23.fc22: * should fix your issue, * was pushed to the Fedora 22 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing cyrus-sasl-2.1.26-23.fc22' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-9190/cyrus-sasl-2.1.26-23.fc22 then log in and leave karma (feedback). cyrus-sasl-2.1.26-23.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |