Bug 1187224
| Summary: | Review Request: python-backport_collections - Backport of Python 2.7's collections module | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Matěj Cepl <mcepl> |
| Component: | Package Review | Assignee: | Dan Horák <dan> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | dan, mcepl, package-review |
| Target Milestone: | --- | Flags: | dan:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | python-backport_collections-0.1-1.el6 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-08 22:39:09 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1179743 | ||
|
Description
Matěj Cepl
2015-01-29 15:14:16 UTC
This https://copr-be.cloud.fedoraproject.org/results/mcepl/piglit-el6/epel-6-x86_64/python-backport_collections-0.1-1.el7/python-backport_collections-0.1-1.el6.src.rpm is more recent package. formal review is here, see the notes explaining OK* and BAD statuses below:
OK source files match upstream:
ca04e8399194a70b10993552ce01b4551bad56ea backport_collections-0.1.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (Python). License text included in package.
OK latest version is being packaged.
OK BuildRequires are proper.
N/A compiler flags are appropriate.
OK package builds in mock (EPEL-6/x86_64).
N/A debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
OK %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
Ok owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.
- my preference is to list BRs on individual lines, it is easier to track changes there
- rpmlint complains a bit from the spell-checker - please fix the "slightly" typo
python-backport_collections.src: W: spelling-error Summary(en_US) Backport -> Back port, Back-port, Backpacker
python-backport_collections.src: W: spelling-error %description -l en_US Backport -> Back port, Back-port, Backpacker
python-backport_collections.src: W: spelling-error %description -l en_US deque -> queue
python-backport_collections.src: W: spelling-error %description -l en_US namedtuple -> nameplate
python-backport_collections.src: W: spelling-error %description -l en_US backported -> back ported, back-ported, backpacked
python-backport_collections.src: W: spelling-error %description -l en_US slighlty -> slightly, slight
The package is APPROVED.
New Package SCM Request ======================= Package Name: python-backport_collections Short Description: Backport of Python 2.7's collections module Upstream URL: https://pypi.python.org/pypi/backport_collections/ Owners: mcepl Branches: el6 Git done (by process-git-requests). python-backport_collections-0.1-1.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/python-backport_collections-0.1-1.el6 python-backport_collections-0.1-1.el6 has been pushed to the Fedora EPEL 6 testing repository. python-backport_collections-0.1-1.el6 has been pushed to the Fedora EPEL 6 stable repository. |