Bug 1187320

Summary: Uncloning a non-cloned resource produces invalid CIB
Product: Red Hat Enterprise Linux 7 Reporter: Radek Steiger <rsteiger>
Component: pcsAssignee: Tomas Jelinek <tojeline>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 7.1CC: cluster-maint, tojeline
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcs-0.9.140-1.el7 Doc Type: Bug Fix
Doc Text:
Cause: User tries to unclone a non-cloned resource. Consequence: pcs produces an invalid CIB, exits with error and dumps the CIB to a terminal. Fix: Check that the resource is cloned. Result: pcs exits gracefully with explanatory error message.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2015-11-19 09:34:29 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
proposed fix none

Description Radek Steiger 2015-01-29 18:50:40 UTC 
> Description of problem:

When trying to unclone a resource, which is not a clone, pcs produces invalid CIB by stripping the resources' parent tag (<resources> in this case).


> Version-Release number of selected component (if applicable):
pcs-0.9.137-13.el7

> How reproducible:
Always

> Steps to Reproduce:
1. pcs resource create dummy0 Dummy
2. pcs resource unclone dummy0


> Actual results:

The whole <resources> element is stripped from CIB:

[root@virt-010 ~]# pcs resource unclone dummy0
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
<cib crm_feature_set="3.0.9" validate-with="pacemaker-2.3" epoch="352" num_updates="0" admin_epoch="0" cib-last-written="Thu Jan 29 19:45:28 2015" have-quorum="1" dc-uuid="2">
  <configuration>
    <crm_config>
      <cluster_property_set id="cib-bootstrap-options">
        <...snip...>
      </cluster_property_set>
    </crm_config>
    <nodes>
      <node id="1" uname="virt-010"/>
      <node id="2" uname="virt-011"/>
      <node id="3" uname="virt-012"/>
      <node id="4" uname="virt-016"/>
    </nodes>
    <constraints/>
    <primitive class="ocf" id="dummy0" provider="heartbeat" type="Dummy">
      <instance_attributes id="dummy0-instance_attributes"/>
      <operations>
        <op id="dummy0-start-timeout-20" interval="0s" name="start" timeout="20"/>
        <op id="dummy0-stop-timeout-20" interval="0s" name="stop" timeout="20"/>
        <op id="dummy0-monitor-interval-10" interval="10" name="monitor" timeout="20"/>
      </operations>
    </primitive>
  </configuration>
Comment 2 Tomas Jelinek 2015-03-23 15:25:15 UTC 
Created attachment 1005449 [details]
proposed fix
Comment 4 Tomas Jelinek 2015-06-04 14:42:25 UTC 
Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.137-13.el7_1.2.x86_64
[root@rh71-node1:~]# pcs resource create dummy dummy
[root@rh71-node1:~]# pcs resource unclone dummy
Error: Unable to update cib
Call cib_replace failed (-203): Update does not conform to the configured schema
...



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el6.x86_64
[root@rh71-node1:~]# pcs resource create dummy dummy
[root@rh71-node1:~]# pcs resource unclone dummy
Error: 'dummy' is not a clone resource
[root@rh71-node1:~]# echo $?
1
Comment 8 errata-xmlrpc 2015-11-19 09:34:29 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html