Bug 1187481
| Summary: | lvm2 2.02.115 breaks storaged, which breaks Cockpit | |||
|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Marius Vollmer <mvollmer> | |
| Component: | lvm2 | Assignee: | Peter Rajnoha <prajnoha> | |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | |
| Severity: | unspecified | Docs Contact: | ||
| Priority: | unspecified | |||
| Version: | 21 | CC: | agk, bmarzins, bmr, dwysocha, heinzm, jonathan, lvm-team, msnitzer, prajnoha, prockai, sgallagh, stefw, tsmetana, zkabelac | |
| Target Milestone: | --- | |||
| Target Release: | --- | |||
| Hardware: | Unspecified | |||
| OS: | Unspecified | |||
| Whiteboard: | ||||
| Fixed In Version: | lvm2-2.02.116-3.fc21 | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | ||
| Clone Of: | ||||
| : | 1211183 (view as bug list) | Environment: | ||
| Last Closed: | 2015-02-02 17:23:39 UTC | Type: | Bug | |
| Regression: | --- | Mount Type: | --- | |
| Documentation: | --- | CRM: | ||
| Verified Versions: | Category: | --- | ||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | ||
| Cloudforms Team: | --- | Target Upstream Version: | ||
| Embargoed: | ||||
| Bug Depends On: | 1211287, 1220344 | |||
| Bug Blocks: | 1211183 | |||
|
Description
Marius Vollmer
2015-01-30 07:34:41 UTC
Looks like lvm2app is unmaintained and storaged should be ported away from it. Would it make sense to remove lvm2app from Fedora (and maybe the world)? Currently, there are several changes in the reporting area of LVM2 code. One of those changes is that we're trying to reuse the same info and status ioctl result for one reporting line, removing a need to call several ioctl per one line of report output which can save some time and resources. Unfortunately, one of the recent changes, where we tried to convert the lv_attr (and hence the lvm_lv_get_attr lvm2app counterpart), we introduced a regression that got unnoticed and it caused some of these "info" and "status" attributes in lv_attr (and the string returned by lvm_lv_get_attr) to have "unknown" (the "X") value. Sorry for that! It should be fixed by this patch now: https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=531cc58d899b7dd1421bfe83f5503aa266390334 I'll do a new update with this fix in for f21. > It should be fixed by this patch now:
Great, thanks!
From reading the patch, I think this doesn't fully fix the regression, unfortunately.
lvm_lv_get_property can't find the "lv_attr" attribute at all anymore, because it's type was changed from LVS to LVSSTATUSINFO, as far as I can tell.
We can easily update storaged to use lvm_lv_get_attr, though.
What do you propose?
Correction: snapshots are recognized. Just looking at the lvm_lv_get_property. You can also use lvm_lv_get_attr - internally, it's the same code which gets the value - in case lvm_lv_get_attr it's direct call to acquire the attr string. The lvm_lv_get_property is the general one for all fields which has some extra wrappers to handle this in general way, but underneath, for the lv_attr, it returns exactly the same as lvm_lv_get_attr. > You can also use lvm_lv_get_attr - internally, it's the same code which gets the value
Yes, but we need to change storaged for that, and rush the new version into Fedora. That's fine, but if you are going to fix the lvm_lv_get_property regression as well, we don't need to even do that.
Yes, if you wait a bit, I think I can fix that. Hopefully today. So this one should fix the issue with lvm_lv_get_property: https://git.fedorahosted.org/cgit/lvm2.git/commit/?id=8650404df1884f1e040aad4343c8db0eac71e125 I've tested that on my machine, but I'll do a scratch for you to test too, just for sure. F21 scratch build here: http://koji.fedoraproject.org/koji/taskinfo?taskID=8781186 > F21 scratch build here:
Awesome! Testing...
(In reply to Marius Vollmer from comment #10) > > F21 scratch build here: > > Awesome! Testing... Works as expected. Lvm_lv_get_property returns good values for "lv_attr" and storaged recognizes volumes as thin pools again. Thanks! OK, there's going to be a new upstream release today anyway, so I'll do rawhide and F21 pkgs then. lvm2-2.02.116-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/lvm2-2.02.116-3.fc21 Package lvm2-2.02.116-3.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lvm2-2.02.116-3.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-1504/lvm2-2.02.116-3.fc21 then log in and leave karma (feedback). lvm2-2.02.116-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. Thanks, excellent service, will shop again! |