Bug 1187539

Summary: Validation error needs to be updated when copying an existing activation-key with blank name
Product: Red Hat Satellite Reporter: Sachin Ghai <sghai>
Component: WebUIAssignee: Christine Fouant <cfouant>
WebUI sub component: Katello QA Contact: jcallaha
Status: CLOSED ERRATA Docs Contact:
Severity: high    
Priority: unspecified CC: bbuckingham, jcallaha, jmontleo
Version: NightlyKeywords: Triaged
Target Milestone: Unspecified   
Target Release: Unused   
Hardware: Unspecified   
OS: Unspecified   
URL: http://projects.theforeman.org/issues/9330
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-08-12 05:22:53 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1188305    
Attachments:
Description Flags
UI raises same error twice in validation error message none

Description Sachin Ghai 2015-01-30 11:35:19 UTC
Created attachment 985945 [details]
UI raises same error twice in validation error message

Description of problem:
Validation error needs to be updated when copying an existing activation-key with blank name. Here you can see the error is mentioned twice

/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler/thread_handler.rb:140:in `accept_and_process_next_request'
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler/thread_handler.rb:108:in `main_loop'
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler.rb:441:in `block (3 levels) in start_threads'
/opt/rh/ruby193/root/usr/share/gems/gems/logging-1.8.1/lib/logging/diagnostic_context.rb:323:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/logging-1.8.1/lib/logging/diagnostic_context.rb:323:in `block in create_with_logging_context'
ActiveRecord::RecordInvalid
name: ["cannot be blank", "can't be blank"]


Version-Release number of selected component (if applicable):
nightly

* apr-util-ldap-1.3.9-3.el6_0.1.x86_64
* candlepin-0.9.38-1.el6.noarch
* candlepin-common-1.0.18-1.el6.noarch
* candlepin-selinux-0.9.38-1.el6.noarch
* candlepin-tomcat6-0.9.38-1.el6.noarch
* elasticsearch-0.90.10-7.el6.noarch
* foreman-1.8.0-0.develop.201501270025gite86494a.el6.noarch
* foreman-compute-1.8.0-0.develop.201501270025gite86494a.el6.noarch
* foreman-gce-1.8.0-0.develop.201501270025gite86494a.el6.noarch
* foreman-libvirt-1.8.0-0.develop.201501270025gite86494a.el6.noarch
* foreman-ovirt-1.8.0-0.develop.201501270025gite86494a.el6.noarch
* foreman-postgresql-1.8.0-0.develop.201501270025gite86494a.el6.noarch
* foreman-proxy-1.8.0-0.develop.201501261316git9ea2ac7.el6.noarch
* foreman-release-1.8.0-0.develop.201501270025gite86494a.el6.noarch
* foreman-selinux-1.8.0-0.develop.201412151103gite2863e4.el6.noarch
* foreman-vmware-1.8.0-0.develop.201501270025gite86494a.el6.noarch
* katello-2.1.0-1.201411061509gitb0b8f43.el6.noarch
* katello-certs-tools-2.0.1-1.el6.noarch
* katello-default-ca-1.0-1.noarch
* katello-installer-2.2.0-1.201501230914git3dbe606.el6.noarch
* katello-installer-base-2.2.0-1.201501230914git3dbe606.el6.noarch
* katello-repos-2.1.1-1.el6.noarch
* katello-server-ca-1.0-1.noarch
* openldap-2.4.39-8.el6.x86_64
* pulp-docker-plugins-0.2.1-0.2.beta.el6.noarch
* pulp-katello-0.3-3.el6.noarch
* pulp-nodes-common-2.5.1-1.el6.noarch
* pulp-nodes-parent-2.5.1-1.el6.noarch
* pulp-puppet-plugins-2.5.1-1.el6.noarch
* pulp-puppet-tools-2.5.1-1.el6.noarch
* pulp-rpm-plugins-2.5.1-1.el6.noarch
* pulp-selinux-2.5.1-1.el6.noarch
* pulp-server-2.5.1-1.el6.noarch
* python-ldap-2.3.10-1.el6.x86_64
* ruby193-rubygem-ldap_fluff-0.3.3-1.el6.noarch
* ruby193-rubygem-net-ldap-0.10.0-1.el6.noarch
* ruby193-rubygem-runcible-1.3.0-1.el6.noarch
* rubygem-hammer_cli-0.1.4-1.201501260908gitf44b8c5.el6.noarch
* rubygem-hammer_cli_foreman-0.1.4-1.201501221305git706b057.el6.noarch
* rubygem-hammer_cli_foreman_bootdisk-0.1.2-1.el6.noarch
*

How reproducible:
always

Steps to Reproduce:
1. create an activation key
2. copy an existing activationkey with blank name
3.

Actual results:
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler/thread_handler.rb:140:in `accept_and_process_next_request'
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler/thread_handler.rb:108:in `main_loop'
/usr/lib/ruby/gems/1.8/gems/passenger-4.0.18/lib/phusion_passenger/request_handler.rb:441:in `block (3 levels) in start_threads'
/opt/rh/ruby193/root/usr/share/gems/gems/logging-1.8.1/lib/logging/diagnostic_context.rb:323:in `call'
/opt/rh/ruby193/root/usr/share/gems/gems/logging-1.8.1/lib/logging/diagnostic_context.rb:323:in `block in create_with_logging_context'
ActiveRecord::RecordInvalid
name: ["cannot be blank", "can't be blank"]


Expected results:
name: ["cannot be blank"] should be sufficient.. no need to have same error twice

Additional info:

Comment 1 RHEL Program Management 2015-01-30 11:43:18 UTC
Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Christine Fouant 2015-02-11 15:13:04 UTC
Created redmine issue http://projects.theforeman.org/issues/9330 from this bug

Comment 4 Bryan Kearney 2015-02-19 01:06:09 UTC
Moving to POST since upstream bug http://projects.theforeman.org/issues/9330 has been closed
-------------
Christine Fouant
Applied in changeset commit:katello|494f3fb494ac269f4433a91ca556aca28aa94298.

Comment 7 jcallaha 2015-02-26 18:34:08 UTC
Verified in Satellite 6.1.0 snap 4 compose 2.

Version tested:
RHEL 66
RHEL 71

Comment 8 Bryan Kearney 2015-08-11 13:34:01 UTC
This bug is slated to be released with Satellite 6.1.

Comment 9 errata-xmlrpc 2015-08-12 05:22:53 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:1592