Bug 1187597

Summary:	sshd -T does not show all (default) options, inconsistency
Product:	Red Hat Enterprise Linux 7	Reporter:	Jakub Jelen <jjelen>
Component:	openssh	Assignee:	Jakub Jelen <jjelen>
Status:	CLOSED ERRATA	QA Contact:	Stanislav Zidek <szidek>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	7.2	CC:	jbelka, jjelen, plautrba, pvrabec, qe-baseos-security, szidek, tmraz
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openssh-6.6.1p1-14.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1109251	Environment:
Last Closed:	2015-11-19 08:02:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1109251
Bug Blocks:	1187521

Comment 1 Jakub Jelen 2015-03-31 15:05:10 UTC

For rhel-7 version applies at least these problems:
 * UsePAM written as number instead of yes|no
 * HostCertificate written with title HostKeyFile
 * missing AllowAgentForwarding
 * Banner default value should be "none"

Comment 5 Stanislav Zidek 2015-05-13 13:13:20 UTC

My findings show that there are two options not dumped by sshd -T:
* allowagentforwarding
* banner

Surprisingly (for me), authenticationmethods IS dumped.

(tested with openssh-6.6.1p1-13.el7.x86_64)

Comment 6 Jakub Jelen 2015-05-14 08:31:44 UTC

Thanks. You are right. I got this fix overwritten by other changes and didn't notice it.

Authenticationmethods was dumped because it was missing one patch from upstream, which prevents printing empty options (invalid input for config):

diff --git a/servconf.c b/servconf.c
index ad5869b..1171c33 100644
--- a/servconf.c
+++ b/servconf.c
@@ -1990,6 +1990,8 @@ dump_cfg_strarray_oneline(ServerOpCodes code, u_int count, char **vals)
 {
 	u_int i;
 
+	if (count <= 0)
+		return;
 	printf("%s", lookup_opcode_name(code));
 	for (i = 0; i < count; i++)
 		printf(" %s",  vals[i]);

I will not be dumped with next build. The problem with default value was reported upstream as 2398 [1] and if there will be some resolution in the near future, I will report back.

[1] https://bugzilla.mindrot.org/show_bug.cgi?id=2398

Comment 10 errata-xmlrpc 2015-11-19 08:02:48 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2088.html