Bug 1187613

MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %license.

According to upstream discussion I guess this is not yet happening, thus this package cannot yet be approved.

Spec URL: https://tradej.fedorapeople.org/reviews/daps/devassistant-dap-common_args/1/devassistant-dap-common_args.spec
SRPM URL: https://tradej.fedorapeople.org/reviews/daps/devassistant-dap-common_args/1/devassistant-dap-common_args-0.10.0-5.fc21.src.rpm
Description: Common arguments used in most of the assistants. Provided arguments: name, path, rpm, docker, eclipse Arguments "github" and "gh_fork" are now provided by the assistant "github", which you need to specify in your Assistant separately.

I was in the process of package review and I found htis in FedoraReview output:

> Package does not contain duplicates in %files.

So I consulted the guidelines, just to be sure, and yes, this is indeed against the guidelines:

http://fedoraproject.org/wiki/Packaging:Guidelines#Duplicate_Files

> A Fedora package must not list a file more than once in the spec
> file's %files listings. If you think your package is a valid
> exception to this, please bring it to the attention of the
> Packaging Committee so they can improve on this Guideline.

So we are still not there, this package is NOT APPROVED.

Otherwise, this package is fine.

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


Issues
======

[!]: Package complies to the Packaging Guidelines
     Note: This is just the consequence of the next point
[!]: Package does not contain duplicates in %files.

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[!]: Package complies to the Packaging Guidelines
     Note: See other issues for explanation.
[x]: Package successfully compiles and builds into binary rpms on at least one
     supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s)
     for the package is included in %license.
[x]: Package does not own files or directories owned by other packages.
[x]: All build dependencies are listed in BuildRequires, except for any that
     are listed in the exceptions section of Packaging Guidelines.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[!]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[-]: Package use %makeinstall only when make install' ' DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as provided
     in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[-]: If the source package does not include license text(s) as a separate file
     from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[?]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[-]: Packages should try to preserve timestamps of original installed files.
[x]: Sources can be downloaded from URI in Source: tag
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: Dist tag is present (not strictly required in GL).
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.


Rpmlint
-------
Checking: devassistant-dap-common_args-0.10.0-5.fc22.noarch.rpm
          devassistant-dap-common_args-0.10.0-5.fc22.src.rpm
devassistant-dap-common_args.noarch: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish
devassistant-dap-common_args.noarch: W: spelling-error %description -l en_US gh -> f, g, h
devassistant-dap-common_args.src: W: spelling-error %description -l en_US github -> git hub, git-hub, thuggish
devassistant-dap-common_args.src: W: spelling-error %description -l en_US gh -> f, g, h
devassistant-dap-common_args.src:43: W: macro-in-%changelog %license
2 packages and 0 specfiles checked; 0 errors, 5 warnings.

All fine.



Requires
--------
devassistant-dap-common_args (rpmlib, GLIBC filtered):
    devassistant-ui



Provides
--------
devassistant-dap-common_args:
    devassistant-dap-common_args



Source checksums
----------------
https://dapi.devassistant.org/download/common_args-0.10.0.dap :
  CHECKSUM(SHA256) this package     : 816991ded90a687dad7419c323d74bf1c1b54f2812883079de2a1d4d3d8fcda8
  CHECKSUM(SHA256) upstream package : 816991ded90a687dad7419c323d74bf1c1b54f2812883079de2a1d4d3d8fcda8

One thing I didn't notice:

devassistant-dap-common_args.src:43: W: macro-in-%changelog %license

Use %%license or drop pre-git changelog entries when importing to git.

Spec URL: https://tradej.fedorapeople.org/reviews/daps/devassistant-dap-common_args/2/devassistant-dap-common_args.spec
SRPM URL: https://tradej.fedorapeople.org/reviews/daps/devassistant-dap-common_args/2/devassistant-dap-common_args-0.10.0-6.fc21.src.rpm
Description: Common arguments used in most of the assistants. Provided arguments: name, path, rpm, docker, eclipse Arguments "github" and "gh_fork" are now provided by the assistant "github", which you need to specify in your Assistant separately.

Fixed. APPROVED.

New Package SCM Request
=======================
Package Name: devassistant-dap-common_args
Short Description: Common arguments to be used from other assistants
Upstream URL: https://github.com/devassistant/dap-common_args
Owners: bkabrda
Branches:
InitialCC:

Git done (by process-git-requests).