Bug 1187873

Summary:	Review Request: perl-Palm-PDB - Parse Palm database files
Product:	[Fedora] Fedora	Reporter:	Emmanuel Seyman <emmanuel>
Component:	Package Review	Assignee:	David Dick <ddick>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ddick, package-review
Target Milestone:	---	Flags:	ddick: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-02-01 20:47:54 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Emmanuel Seyman 2015-01-31 10:08:52 UTC

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Palm-PDB/perl-Palm-PDB.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Palm-PDB/perl-Palm-PDB-1.016-1.fc21.src.rpm

Description:
The Palm::PDB module provides a framework for reading and writing database
files for use on PalmOS devices such as the PalmPilot. It can read and
write both Palm Database (.pdb) and Palm Resource (.prc) files.

Fedora Account System Username: eseyman

Rpmlint output:
perl-Palm-PDB.src: W: spelling-error %description -l en_US prc -> PRC, pr, pic
1 packages and 1 specfiles checked; 0 errors, 1 warnings.

Comment 1 David Dick 2015-01-31 11:36:14 UTC

License is correct.

examples can be included in %doc

include the following BRs

perl(warnings)
perl(strict)

rpmlint is fine (ignoring incorrect spelling warnings)

package builds fine locally (koji seems to be having some SSL certificate issues at the moment)

if you are building only for F21, 

"find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;" looks like it can be replaced with NO_PACKLIST=1 as a Makefile.PL argument.

otherwise you'll need to adjust the %license key?

Package APPROVED

Comment 2 Emmanuel Seyman 2015-01-31 14:37:46 UTC

(In reply to David Dick from comment #1)
> 
> include the following BRs
> 
> perl(warnings)
> perl(strict)

Done.

> if you are building only for F21, 

Rawhide only, actually.
Fedora has the package perl-p5-Palm. A while back, the CPAN distribution was:

a) renamed to simply Palm
b) split into Palm and Palm-PDB
c) updated

So the plan is to package Palm-PDB (this bug) in rawhide and then rename perl-p5-Palm to perl-Palm (which will require another review).

> "find $RPM_BUILD_ROOT -type f -name .packlist -exec rm -f {} \;" looks like
> it can be replaced with NO_PACKLIST=1 as a Makefile.PL argument.

Done

Spec URL: http://people.parinux.org/~seyman/fedora/perl-Palm-PDB/perl-Palm-PDB.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-Palm-PDB/perl-Palm-PDB-1.016-2.fc21.src.rpm

Thanks for the review, David.
Requesting SCM

New Package SCM Request
=======================
Package Name: perl-Palm-PDB
Short Description: Parse Palm database files
Upstream URL: http://search.cpan.org/dist/Palm-PDB//pkgname
Owners: eseyman
Branches:
InitialCC: perl-sig

Comment 3 Gwyn Ciesla 2015-02-01 15:46:28 UTC

Git done (by process-git-requests).

Comment 4 Emmanuel Seyman 2015-02-01 20:47:54 UTC

Imported and built for rawhide.
Thanks for the git repo, Jon.