Bug 1188524

Package fails to build with mock. You can run mock with:
mock --rebuild nodejs-date-tokens-0.0.2-1.fc21.src.rpm
to check if your package will build correctly. Please do a mock build before issue'ing a review request.

The error is caused by a missing 
BuildRequires: nodejs-packaging


rpmlint gives an error, you can run:
rpmlint package.spec package.rpm package.src.rpm
to check if your package is ok.

rpmlint ~/rpmbuild/SPECS/nodejs-date-tokens.spec ~/rpmbuild/SRPMS/nodejs-date-tokens-0.0.2-1.fc21.src.rpm ~/rpmbuild/RPMS/noarch/nodejs-date-tokens-0.0.2-1.fc21.noarch.rpm 
nodejs-date-tokens.src: E: description-line-too-long C Date tokens offers convenient ways to use date functions in mustache style templates
nodejs-date-tokens.noarch: E: description-line-too-long C Date tokens offers convenient ways to use date functions in mustache style templates
nodejs-date-tokens.noarch: W: only-non-binary-in-usr-lib
2 packages and 1 specfiles checked; 2 errors, 1 warnings.

Hi Piotr,

Thank you for package review, please find upadated spec and srpms on 

Spec URL: https://anishpatil.fedorapeople.org/nodejs-date-tokens.spec
SRPM URL: https://anishpatil.fedorapeople.org/nodejs-date-tokens-0.0.2-2.fc21.src.rpm

Could you please remove the second %check section.

I have enabled the tests and they fail:

  date-tokens
    + dt
      ✓ should return the tokens object of functions 
      ✓ should return the tokens object of functions, if function called, should return current time 
      ✓ should return the tokens object of functions, if function called without param, should use param in dt() 
      ✓ should return the tokens object of functions, if function called with param, should use param 
      ✓ should return the tokens object of functions with tokens named with the prefix 
      ✓ should return the tokens object of functions with tokens named with the prefix and current time 
    + eval
      ✓ should return the tokens object of strings of eval'd dates 
      ✓ should return the tokens object of strings and should return current time 
      1) should return the tokens object of strings should use param in eval()
      ✓ should return the tokens object of strings with tokens named with the prefix 
      ✓ should return the tokens object of strings with tokens named with the prefix and return current 


  10 passing (14ms)
  1 failing

  1) date-tokens + eval should return the tokens object of strings should use param in eval():
     AssertionError: false == true
      at Context.<anonymous> (/home/piotr/rpmbuild/BUILD/node-date-tokens-0.0.2/test/date-tokens.test.js:86:13)
      at callFn (/usr/lib/node_modules/mocha/lib/runnable.js:223:21)
      at Test.Runnable.run (/usr/lib/node_modules/mocha/lib/runnable.js:216:7)
      at Runner.runTest (/usr/lib/node_modules/mocha/lib/runner.js:374:10)
      at /usr/lib/node_modules/mocha/lib/runner.js:452:12
      at next (/usr/lib/node_modules/mocha/lib/runner.js:299:14)
      at /usr/lib/node_modules/mocha/lib/runner.js:309:7
      at next (/usr/lib/node_modules/mocha/lib/runner.js:247:23)
      at Object._onImmediate (/usr/lib/node_modules/mocha/lib/runner.js:276:5)
      at processImmediate [as _immediateCallback] (timers.js:345:15)




Could you check why they fail? Tests are a good indicator if the library actually works as intended.

Thank you for your comments, test case is failing becuase there is a problem with test case result itself, I have created a new pull request in upstream to fix test case itself.
https://github.com/jprichardson/node-date-tokens/pull/2


Please fine new SRPM and spec as 

Spec URL: https://anishpatil.fedorapeople.org/nodejs-date-tokens.spec
SRPM URL: https://anishpatil.fedorapeople.org/nodejs-date-tokens-0.0.2-3.fc21.src.rpm

Good work for fixing the test!

Could you add the missing symlink for the dependencies?

https://fedoraproject.org/wiki/Packaging:Node.js?rd=Node.js/Packagers#Symlinking_Dependencies

Hi Piotr,

Thank you!! Please find updated rpms and sprms on 


Spec URL: https://anishpatil.fedorapeople.org/nodejs-date-tokens.spec
SRPM URL: https://anishpatil.fedorapeople.org/nodejs-date-tokens-0.0.2-4.fc21.src.rpm

Please update Source0 to comply with github guidelines:
https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github

Please move LICENSE from %doc to %license:
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines


Please remove test/ from %doc. It's not needed to include tests in %doc

Anish, any updates on this?

This seems stalled, closing bug in one week.
https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews

The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days