Bug 1188763
| Summary: | Review Request: nodejs-ultron - Ultron is a high-intelligence robot | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Troy Dawson <tdawson> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-ultron-1.0.1-3.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-02-25 13:31:06 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1191708 | ||
|
Description
Troy Dawson
2015-02-03 16:30:33 UTC
Here is a scratch build, on rawhide, if it helps. http://koji.fedoraproject.org/koji/taskinfo?taskID=8810892 Review: + mock build is successful for f22 + rpmlint output on rpms gave nodejs-ultron.noarch: W: only-non-binary-in-usr-lib 2 packages and 0 specfiles checked; 0 errors, 1 warnings. + Source verified with upstream as (sha256sum) srpm tarball : c13a9cc61bb53dc24afa50afbfeff31f31b539a005702c1a742c07001a97cd5d upstream tarball : c13a9cc61bb53dc24afa50afbfeff31f31b539a005702c1a742c07001a97cd5d + License "MIT" is valid - License text is not available + rest looks following packaging guidelines Suggestions: 1) Group tag is optional and can be removed. 2) Ask upstream to provide license text. File issue upstream. Either wait for upstream to add license file or add yourself license file as Source1 in spec. Spec URL: https://tdawson.fedorapeople.org/nodejs/nodejs-ultron.spec SRPM URL: https://tdawson.fedorapeople.org/nodejs/nodejs-ultron-1.0.1-2.fc22.src.rpm - License: -- I have pinged upstream about providing a license file --- https://github.com/unshiftio/ultron/issues/4 -- I have also included an MIT license file as Source1, so the review can continue. - Group: -- I have removed the group line Thanks. Looks good now but include the LICENSE file that upstream has committed when you import this package which includes Author name APPROVED. Will do. Thanks. New Package SCM Request ======================= Package Name: nodejs-ultron Short Description: Ultron is a high-intelligence robot Upstream URL: https://github.com/unshiftio/ultron Owners: tdawson Branches: f20 f21 f22 el6 epel7 InitialCC: Git done (by process-git-requests). nodejs-ultron-1.0.1-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-ultron-1.0.1-3.fc21 nodejs-ultron-1.0.1-3.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-ultron-1.0.1-3.fc20 nodejs-ultron-1.0.1-3.fc21 has been pushed to the Fedora 21 testing repository. nodejs-ultron-1.0.1-3.fc20 has been pushed to the Fedora 20 stable repository. nodejs-ultron-1.0.1-3.fc21 has been pushed to the Fedora 21 stable repository. |