Bug 1189023
| Summary: | Directories not visible anymore after add-brick, new brick dirs not part of old bricks | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Pranith Kumar K <pkarampu> |
| Component: | distribute | Assignee: | Raghavendra G <rgowdapp> |
| Status: | CLOSED UPSTREAM | QA Contact: | |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | 3.6.1 | CC: | bugs, cww, dblack, gluster-bugs, nbalacha, pkarampu, rabhat, rgowdapp, spalai, srangana, storage-qa-internal, vgaikwad |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1176008 | Environment: | |
| Last Closed: | 2015-11-27 09:35:31 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1162306, 1176008 | ||
| Bug Blocks: | 1177928, 1184460 | ||
|
Comment 1
Anand Avati
2015-02-04 09:24:20 UTC
afr part of the fix is sent for review. Dht patch also needs to be sent out for the complete fix. Assigning to Raghavendra G for now. COMMIT: http://review.gluster.org/9576 committed in release-3.6 by Raghavendra Bhat (raghavendra) ------ commit 73835a06e87f685354816fb6c2ca4a9918f5e314 Author: Pranith Kumar K <pkarampu> Date: Wed Dec 31 15:15:53 2014 +0530 cluster/afr: serialize inode locks Backport of http://review.gluster.org/9372 Problem: Afr winds inodelk calls without any order, so blocking inodelks from two different mounts can lead to dead lock when mount1 gets the lock on brick-1 and blocked on brick-2 where as mount2 gets lock on brick-2 and blocked on brick-1 Fix: Serialize the inodelks whether they are blocking inodelks or non-blocking inodelks. Non-blocking locks also need to be serialized. Otherwise there is a chance that both the mounts which issued same non-blocking inodelk may endup not acquiring the lock on any-brick. Ex: Mount1 and Mount2 request for full length lock on file f1. Mount1 afr may acquire the partial lock on brick-1 and may not acquire the lock on brick-2 because Mount2 already got the lock on brick-2, vice versa. Since both the mounts only got partial locks, afr treats them as failure in gaining the locks and unwinds with EAGAIN errno. BUG: 1189023 Change-Id: If5dd502d9d25d12425749a8efcf08a1423b29255 Signed-off-by: Pranith Kumar K <pkarampu> Reviewed-on: http://review.gluster.org/9576 Reviewed-by: Krutika Dhananjay <kdhananj> Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra Bhat <raghavendra> v3.6.7 has the fix |