Bug 1189157

Summary: RHOS Unable to provision an openstack instance in a non-admin tenant with only a shared network
Product: Red Hat CloudForms Management Engine Reporter: Jan Krocil <jkrocil>
Component: AutomateAssignee: Brandon Dunne <bdunne>
Status: CLOSED ERRATA QA Contact: Pavol Kotvan <pakotvan>
Severity: medium Docs Contact:
Priority: medium    
Version: 5.3.0CC: cpelland, dclarizi, gblomqui, gmccullo, jhardy, mfeifer, obarenbo, xlecauch
Target Milestone: GA   
Target Release: 5.5.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: 5.5.0.1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-08 13:02:38 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot - provision new instance with shared network into tenant none

Description Jan Krocil 2015-02-04 15:26:03 UTC
Description of problem:
RHOS{3,4,5}:
Unable to provision an instance in a tenant that doesn't have a dedicated network but has only access to a shared one.

From my POV it would seem that there is a check like this somewhere:
"network.proj_id == proj.id"

when it really should be more like this:
"network.is_shared || network.proj_id == proj.id"

Version-Release number of selected component (if applicable):
5.3.3.0.1 - 5.3.3.0.1.20150127115148_446974b

How reproducible:
Always with RHOS3,4,5

Steps to Reproduce:
1. Add a RHOS provider
2. Try to provision an instance in a non-admin tenant into a shared cloud network

Actual results:
The shared network does not show up in the "Cloud network" selectbox even though it should (as I can see it in the RHOS web ui being available to the non-admin tenant).

Expected results:
User is able to select a shared network from the Cloud Network selectbox.

Additional info:

Comment 2 Greg McCullough 2015-02-05 15:06:49 UTC
Brandon - Do we collect enough data during inventory to determine a shared network?

Comment 3 Brandon Dunne 2015-02-05 15:29:17 UTC
Greg - No, we do not currently collect whether or not the network is shared.

Comment 4 CFME Bot 2015-07-07 18:34:22 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/aef53515b9add8227254899b3bc0f0d2982b156c

commit aef53515b9add8227254899b3bc0f0d2982b156c
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Jul 2 11:12:30 2015 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Tue Jul 7 09:54:49 2015 -0400

    Collect network shared status on refresh
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1189157

 app/models/ems_refresh/parsers/openstack.rb              | 1 +
 db/migrate/20150701191241_add_shared_to_cloud_network.rb | 5 +++++
 2 files changed, 6 insertions(+)
 create mode 100644 db/migrate/20150701191241_add_shared_to_cloud_network.rb

Comment 5 CFME Bot 2015-07-07 18:34:26 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/a9951bbe293080b0e9c97d9cedd187ef0aaf065b

commit a9951bbe293080b0e9c97d9cedd187ef0aaf065b
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Jul 2 11:16:43 2015 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Tue Jul 7 09:54:50 2015 -0400

    Add more CloudNetwork relationships
    
    :cloud_networks        -> CloudNetworks owned by this CloudTenant
    :direct_cloud_networks -> same ^
    :shared_cloud_networks -> CloudNetworks in other tenants that are shared with this CloudTenant
    :all_cloud_networks    -> CloudNetworks owned by and shared with this CloudTenant
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1189157

 app/models/cloud_tenant.rb                     |  7 +++++++
 app/models/manageiq/providers/cloud_manager.rb |  2 ++
 spec/models/cloud_tenant_spec.rb               | 14 ++++++++++++++
 3 files changed, 23 insertions(+)
 create mode 100644 spec/models/cloud_tenant_spec.rb

Comment 6 CFME Bot 2015-07-07 18:34:30 UTC
New commit detected on manageiq/master:
https://github.com/ManageIQ/manageiq/commit/fc4153696ee640776447329917a58143596366f5

commit fc4153696ee640776447329917a58143596366f5
Author:     Brandon Dunne <bdunne>
AuthorDate: Thu Jul 2 11:17:38 2015 -0400
Commit:     Brandon Dunne <bdunne>
CommitDate: Tue Jul 7 09:54:50 2015 -0400

    Allow selection of all accessible CloudNetworks during provisioning
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1189157

 app/models/miq_provision_cloud_workflow.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comment 8 Pavol Kotvan 2015-11-20 15:29:14 UTC
Verified against 5.5.0.11. I was able provision new instance in a non-admin tenant into a external/shared cloud network. This was tested against RHOS5.

Comment 9 Pavol Kotvan 2015-11-20 15:31:05 UTC
Created attachment 1097249 [details]
Screenshot - provision new instance with shared network into tenant

Comment 11 errata-xmlrpc 2015-12-08 13:02:38 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2015:2551