Bug 1189200

Summary: traceback in ioprocess while restarting VDSM
Product: [oVirt] vdsm Reporter: Sandro Bonazzola <sbonazzo>
Component: GeneralAssignee: Yaniv Bronhaim <ybronhei>
Status: CLOSED CURRENTRELEASE QA Contact: Jiri Belka <jbelka>
Severity: high Docs Contact:
Priority: unspecified    
Version: ---CC: amureini, bazulay, bugs, lsurette, mgoldboi, oourfali, pstehlik, rbalakri, srevivo, ybronhei, ycui, ykaul
Target Milestone: ovirt-4.0.0-alphaFlags: rule-engine: ovirt-4.0.0+
rule-engine: planning_ack+
oourfali: devel_ack+
pstehlik: testing_ack+
Target Release: 4.18.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: ovirt 4.0.0 alpha1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-07-05 07:40:42 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Infra RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1193824    
Bug Blocks:    

Description Sandro Bonazzola 2015-02-04 16:42:08 UTC
For reproducing just use:

# service vdsmd restart

 MainThread::DEBUG::2015-02-04 08:45:33,702::vdsm::58::vds::(sigtermHandler) Received signal 15
 MainThread::DEBUG::2015-02-04 08:45:33,702::protocoldetector::144::vds.MultiProtocolAcceptor::(stop) Stopping Acceptor
 MainThread::INFO::2015-02-04 08:45:33,703::__init__::565::jsonrpc.JsonRpcServer::(stop) Stopping JsonRPC Server
 Detector thread::DEBUG::2015-02-04 08:45:33,703::protocoldetector::115::vds.MultiProtocolAcceptor::(_cleanup) Cleaning Acceptor
 ioprocess communication (561)::ERROR::2015-02-04 08:45:33,702::__init__::152::IOProcessClient::(_communicate) IOProcess failure
 Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/ioprocess/__init__.py", line 107, in _communicate
    raise Exception("FD closed")
 Exception: FD closed
 ioprocess communication (571)::ERROR::2015-02-04 08:45:33,702::__init__::152::IOProcessClient::(_communicate) IOProcess failure
 Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/ioprocess/__init__.py", line 107, in _communicate
    raise Exception("FD closed")
 Exception: FD closed
 MainThread::INFO::2015-02-04 08:45:33,704::vmchannels::188::vds::(stop) VM channels listener was stopped.


The exception should be properly handled.

 # rpm -qa |egrep "(vdsm|iopro|libvir)"|sort
 ioprocess-0.15.0-1.el7.x86_64
 libvirt-client-1.2.8-16.el7.x86_64
 libvirt-daemon-1.2.8-16.el7.x86_64
 libvirt-daemon-config-nwfilter-1.2.8-16.el7.x86_64
 libvirt-daemon-driver-interface-1.2.8-16.el7.x86_64
 libvirt-daemon-driver-network-1.2.8-16.el7.x86_64
 libvirt-daemon-driver-nodedev-1.2.8-16.el7.x86_64
 libvirt-daemon-driver-nwfilter-1.2.8-16.el7.x86_64
 libvirt-daemon-driver-qemu-1.2.8-16.el7.x86_64
 libvirt-daemon-driver-secret-1.2.8-16.el7.x86_64
 libvirt-daemon-driver-storage-1.2.8-16.el7.x86_64
 libvirt-daemon-kvm-1.2.8-16.el7.x86_64
 libvirt-lock-sanlock-1.2.8-16.el7.x86_64
 libvirt-python-1.2.8-7.el7.x86_64
 python-ioprocess-0.15.0-1.el7.noarch
 vdsm-4.17.0-365.git5bc5813.el7.x86_64
 vdsm-cli-4.17.0-365.git5bc5813.el7.noarch
 vdsm-gluster-4.17.0-365.git5bc5813.el7.noarch
 vdsm-infra-4.17.0-365.git5bc5813.el7.noarch
 vdsm-jsonrpc-4.17.0-365.git5bc5813.el7.noarch
 vdsm-python-4.17.0-365.git5bc5813.el7.noarch
 vdsm-python-zombiereaper-4.16.11-10.gitc3e02dd.el7.noarch
 vdsm-xmlrpc-4.17.0-365.git5bc5813.el7.noarch
 vdsm-yajsonrpc-4.17.0-365.git5bc5813.el7.noarch

Comment 1 Yeela Kaplan 2015-08-20 13:18:40 UTC
Currently when stopping vdsm, ioprocess gets the same TERM signal as vdsm. 
using mixed KillMode will prevent ioprocess from terminating unexpectely.. 
Adding dependency to mixed KillMode,
looks like it will be available on el7.2

Comment 2 Yeela Kaplan 2015-10-22 09:06:13 UTC
Killmode mixed is supported only starting EL7.2. 

Patch will be merged only when vdsm stops support for EL7.1.

Comment 3 Yaniv Lavi 2015-10-29 12:11:57 UTC
In oVirt testing is done on single release by default. Therefore I'm removing the 4.0 flag. If you think this bug must be tested in 4.0 as well, please re-add the flag. Please note we might not have testing resources to handle the 4.0 clone.

Comment 4 Red Hat Bugzilla Rules Engine 2016-01-27 10:01:33 UTC
This bug is marked for z-stream, yet the milestone is for a major version, therefore the milestone has been reset.
Please set the correct milestone or drop the z stream flag.

Comment 5 Jiri Belka 2016-05-31 08:39:54 UTC
ok, vdsm-4.18.0-0.el7ev.x86_64

can't reproduce with above version

Comment 6 Sandro Bonazzola 2016-07-05 07:40:42 UTC
oVirt 4.0.0 has been released, closing current release.