Bug 1189329
| Summary: | xorg-x11-drv-synaptics-1.8.1-2.fc21 patch for new Lenovo touchpads is incorrect | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Aron Parsons <aronparsons> | ||||||||
| Component: | xorg-x11-drv-synaptics | Assignee: | Peter Hutterer <peter.hutterer> | ||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 21 | CC: | aronparsons, hdegoede, peter.hutterer | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | xorg-x11-drv-synaptics-1.8.1-3.fc21 | Doc Type: | Bug Fix | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2015-02-08 08:56:35 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
Created attachment 988350 [details]
spec file patch
Created attachment 988351 [details]
50-synaptics.conf
not sure why we replace the file wholesale versus using upstream (didn't diff or look into it), so here is an updated file that contains the necessary additions.
Created attachment 988352 [details]
spec file patch
add %post/%postun scriptlets to reload the udev rules since we drop some in place
how embarrassing. must've picked up my local rules during testing, sorry about that. I don't think the BuildRequires: systemd is correct though. That is needed for post/postun so shouldn't this be a Requires then? in which case we can just leave it out, we don't have systems without systemd. (In reply to Peter Hutterer from comment #4) > how embarrassing. must've picked up my local rules during testing, sorry > about that. > > I don't think the BuildRequires: systemd is correct though. That is needed > for post/postun so shouldn't this be a Requires then? in which case we can > just leave it out, we don't have systems without systemd. systemd provides the RPM macro _udevrulesdir. It wasn't pulled in the mock build environment. I'm fairly sure the koji package group does not actually include systemd either. You can verify by doing a scratch build without that requires statement. right, that makes sense. Thanks for the patch, applied and pushed. Rawhide is here: http://koji.fedoraproject.org/koji/taskinfo?taskID=8825638 Fedora 21 build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8825705 xorg-x11-drv-synaptics-1.8.1-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/xorg-x11-drv-synaptics-1.8.1-3.fc21 Package xorg-x11-drv-synaptics-1.8.1-3.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing xorg-x11-drv-synaptics-1.8.1-3.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2015-1769/xorg-x11-drv-synaptics-1.8.1-3.fc21 then log in and leave karma (feedback). xorg-x11-drv-synaptics-1.8.1-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. |
Description of problem: xorg-x11-drv-synaptics-1.8.1-2.fc21 added a patch for the new Lenovo touchpads. However, the spec file is not laying down a couple of the files correctly. The xorg.conf.d file is replaced wholesale by the spec file, so the upstream additions didn't make it. And the new udev rules is incorrectly in the -devel subpackage. Version-Release number of selected component (if applicable): xorg-x11-drv-synaptics-1.8.1-2.fc21 How reproducible: always Actual results: $ rpm -ql xorg-x11-drv-synaptics | grep udev /usr/lib/udev/rules.d/70-touchpad-quirks.rules $ grep has_trackpoint /usr/share/X11/xorg.conf.d/50-synaptics.conf Expected results: $ rpm -ql xorg-x11-drv-synaptics | grep udev /usr/lib/udev/rules.d/70-touchpad-quirks.rules /usr/lib/udev/rules.d/71-synaptics.rules $ grep has_trackpoint /usr/share/X11/xorg.conf.d/50-synaptics.conf Identifier "Lenovo *50 and Carbon 3rd trackpoint buttons" MatchTag "has_trackpoint_buttons" Additional info: patch for the spec file is attached as well as the updated 50-synaptics.conf file. I also modified the spec file to use the %{_udevrulesdir} macro, which is provied by the macros from systemd. This adds systemd as a build dependency.